ofborg icon indicating copy to clipboard operation
ofborg copied to clipboard

No review requests on modules & tests

Open mweinelt opened this issue 4 years ago • 2 comments

Tested all four combinations of changes to tests/modules with person/teams set as meta.maintainers, and never got a request to review. This is quite a serious defect in our reviewing system.

https://github.com/NixOS/nixpkgs/pull/128447

mweinelt avatar Jun 27 '21 22:06 mweinelt

We can get a list of maintainers for files/modules via:

nix-instantiate --eval '<nixpkgs/nixos>' --arg configuration '{}' -A config.meta.maintainers --strict --json

(cc @Infinisil)

andir avatar Nov 05 '21 17:11 andir

Attempt in #641

RaitoBezarius avatar May 04 '23 22:05 RaitoBezarius