ofborg icon indicating copy to clipboard operation
ofborg copied to clipboard

[Feature request] Select platform

Open NeQuissimus opened this issue 8 years ago • 6 comments

I propose that it should either be possible to select a target platform or (minimally) Borg should not report errors for platforms that are specifically not supported (like a Linux kernel on Darwin :D)

NeQuissimus avatar Nov 22 '17 22:11 NeQuissimus

It is hard to know if something intentionally or doesn't intentionally support a platform. For example: https://github.com/NixOS/nixpkgs/pull/31737/commits broke support unintentionally on all platforms. Because we test on every platform automatically, we determined the problem prior to merging. What is the right thing to do here?

grahamc avatar Nov 23 '17 19:11 grahamc

Not sure, maybe just assume all of them unless we somehow define it? Maybe like this?

@grahamcofborg build linux_4_14 on x64_linux

where the on x64_linux is optional?

NeQuissimus avatar Nov 23 '17 19:11 NeQuissimus

Ok, I can see the value here. However, I find it much less valuable compared to #2, just fwiw. I think the error messages from Darwin are not so bad for the time being.

grahamc avatar Nov 24 '17 12:11 grahamc

One way that would make more sense to me is switching to an aggregated reply method, combined with detecting that the package is not supported. Then a reply could look like:

Package <xyz> does not support Darwin.

Success on x8664linux:
> ...
> ...

however, this isn't something I'd feel comfortable doing until we had several more macs and linux boxes building.

grahamc avatar Nov 24 '17 13:11 grahamc

cc @lnl7 how is the sandboxing coming along? Will it backport to 17.09?

grahamc avatar Nov 24 '17 13:11 grahamc

I ran into some issues, but I suspect it's hydra related. I'll probably look at it during the weekend.

LnL7 avatar Nov 24 '17 18:11 LnL7