ofborg icon indicating copy to clipboard operation
ofborg copied to clipboard

eval gist contains tests.nixos-functions.nixos-test in change attrset

Open Mic92 opened this issue 7 years ago • 6 comments

All evaluations now contain two attributes:

  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test

in its changed attrset

Building those will also try to build a kernel. nix-review currently try to build all packages in this file.

Mic92 avatar Nov 15 '18 11:11 Mic92

When evaluating the same nixpkgs revision with:

$ nix-env -f path -qaP --xml --out-path --show-trace

those attributes do not appear.

Mic92 avatar Nov 15 '18 11:11 Mic92

Ok. It also appears now in my own evaluation.

Mic92 avatar Nov 15 '18 12:11 Mic92

cc @roberth

Mic92 avatar Nov 15 '18 12:11 Mic92

I was assuming that these were simply not built on hydra and therefore show up here as 'new'. I do not know whether that's really the case. Another possibility is that it shows up often because it has a significant number of dependencies. That may not be the problem if "All evaluations now contain two attributes" is correct. I don't have time to investigate in the coming days. If it is unbearable, just comment the nixos-functions reference. Also, I'll look into making these test evaluation-only, because that provides 99% of the value anyway - making sure that the Nix glue is correct, not necessarily that NixOS builds correctly. We have nixos/release.nix for that, at its own pace.

roberth avatar Nov 15 '18 12:11 roberth

Does it mean that nixos has now to be evaluated when searching packages?

Mic92 avatar Nov 15 '18 12:11 Mic92

Depends where you're searching. pkgs.tests: yes pkgs.nixosTests: yes pkgs.nixosTest: no (evaluates directly to a lambda without defaults, so no auto-call) pkgs.nixos: no (same)

roberth avatar Nov 15 '18 14:11 roberth