nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

perlPackages.DBDPg: fix build with gcc15

Open ghpzin opened this issue 1 month ago • 1 comments

  • add patch from merged upstream PR: https://www.github.com/bucardo/dbdpg/pull/148 https://github.com/bucardo/dbdpg/commit/8da04f9169d017469e3a12f08322e6bd88e8f239

Upstream issue: https://www.github.com/bucardo/dbdpg/issues/135

Fixes build failure with gcc15:

Pg.xs: In function 'XS_DBD__Pg__db_quote':
Pg.xs:330:22: error: too many arguments to function 'type_info->quote';
expected 0, have 5
  330 |             quoted = type_info->quote(aTHX_ to_quote, len, &retlen, imp_dbh->pg_server_version >= 80100 ? 1 : 0);
      |                      ^~~~~~~~~
In file included from Pg.h:66,
                 from Pg.xs:14:
types.h:11:15: note: declared here
   11 |     char*   (*quote)();
      |               ^~~~~

Tested build with:

nix-build --expr 'with import ./. {}; (perlPackages.overrideScope (final: prev: { stdenv = gcc15Stdenv; })).DBDPg'

Part of fixes for gcc15 update: https://github.com/NixOS/nixpkgs/pull/440456


There might be a version update (3.19.0) with this fix included soon, but it is not in cpan yet: https://github.com/bucardo/dbdpg/commit/d02e38fa462360e63964f88617ac636a6e8096e2

Things done

  • Built on platform:
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • Tested, as applicable:
  • [x] Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • [x] Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • [ ] Package update: when the change is major or breaking.
  • NixOS Release Notes
    • [ ] Module addition: when adding a new NixOS module.
    • [ ] Module update: when the change is significant.
  • [x] Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a :+1: reaction to pull requests you find important.

ghpzin avatar Dec 13 '25 15:12 ghpzin

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 470467 Commit: d2d7e632d4aad9934bf054ec2a17f0ebd67e90c4


x86_64-linux

:x: 1 package failed to build:
  • sympa
:white_check_mark: 21 packages built:
  • hydra
  • hydra.doc
  • munin
  • parallel-full
  • parallel-full.doc
  • parallel-full.man
  • perl538Packages.DBDPg
  • perl538Packages.DBDPg.devdoc
  • perl538Packages.MojoPg
  • perl538Packages.MojoPg.devdoc
  • perl538Packages.TestPostgreSQL
  • perl538Packages.TestPostgreSQL.devdoc
  • perlPackages.DBDPg (perl540Packages.DBDPg)
  • perlPackages.DBDPg.devdoc (perl540Packages.DBDPg.devdoc)
  • perlPackages.MojoPg (perl540Packages.MojoPg)
  • perlPackages.MojoPg.devdoc (perl540Packages.MojoPg.devdoc)
  • perlPackages.TestPostgreSQL (perl540Packages.TestPostgreSQL)
  • perlPackages.TestPostgreSQL.devdoc (perl540Packages.TestPostgreSQL.devdoc)
  • pgtop
  • rt
  • sqitchPg

Error logs: `x86_64-linux`
sympa
find: 'po/sympa/add-lang.pl': No such file or directory
applying patch /nix/store/npcmkdk30if0xgwkbcysvdlfkfn7sa0j-make-docs.patch
patching file doc/Makefile.am
Hunk #1 succeeded at 93 (offset 10 lines).
Running phase: autoreconfPhase
@nix { "action": "setPhase", "phase": "autoreconfPhase" }
autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force 
configure.ac:30: warning: macro 'AM_PO_SUBDIRS' not found in library
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not using Libtool
autoreconf: configure.ac: not using Intltool
autoreconf: configure.ac: not using Gtkdoc
autoreconf: running: /nix/store/0a184ki65w8ra3qmn2qc8clamfjmxdfz-autoconf-2.72/bin/autoconf --force
configure.ac:30: error: possibly undefined macro: AM_PO_SUBDIRS
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: error: /nix/store/0a184ki65w8ra3qmn2qc8clamfjmxdfz-autoconf-2.72/bin/autoconf failed with exit status: 1

sympa does not build on master

ghpzin avatar Dec 13 '25 16:12 ghpzin