nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

prometheus: Move assets to npmBuildPackage

Open jpds opened this issue 2 months ago • 7 comments

Moves the web UI assets to a npmBuildPackage derivation. Trying to enable nix-update-script so the bot can handle upgrades.

Things done

  • Built on platform:
    • [X] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • Tested, as applicable:
  • [ ] Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • [ ] Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • [ ] Package update: when the change is major or breaking.
  • NixOS Release Notes
    • [ ] Module addition: when adding a new NixOS module.
    • [ ] Module update: when the change is significant.
  • [X] Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a :+1: reaction to pull requests you find important.

jpds avatar Oct 23 '25 13:10 jpds

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 454900 Commit: ae86cd2c113b84a3b696d330fe79ead8a31850ec (subsequent changes) Merge: 6f96bb71b84b2aabdb55743543cc378c94b1a8d7

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18752606228


x86_64-linux

:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli
  • prometheus.doc

aarch64-linux

:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli
  • prometheus.doc

x86_64-darwin (sandbox = true)

:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli
  • prometheus.doc

aarch64-darwin (sandbox = true)

:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli
  • prometheus.doc

Sigmanificient avatar Oct 23 '25 16:10 Sigmanificient

Forgot the checkPhase for the NPM part, readded.

jpds avatar Oct 23 '25 16:10 jpds

Awesome! Thanks for keeping prometheus in shape! :heart: I'll take a look later today.

fpletz avatar Oct 24 '25 09:10 fpletz

And before I forget: Do you also want to add yourself as maintainer while we're at it? Would be much appreciated.

fpletz avatar Oct 24 '25 09:10 fpletz

Pushed up a now fully working update.sh (tested with new .3).

jpds avatar Oct 30 '25 17:10 jpds

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454900 --package prometheus Commit: 55465f4bb72d1e68971eaef11348235f9a3af0b7


x86_64-linux

:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli (prometheus.cli.cli, prometheus.cli.doc)
  • prometheus.doc (prometheus.doc.cli, prometheus.doc.doc)

jpds avatar Nov 12 '25 16:11 jpds

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 454900 Commit: b1f7f9b505af025e4ca54ba72272177862435bd1


x86_64-linux

:fast_forward: 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli
  • prometheus.doc

aarch64-linux

:fast_forward: 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli
  • prometheus.doc

x86_64-darwin

:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli
  • prometheus.doc

aarch64-darwin

:white_check_mark: 3 packages built:
  • prometheus
  • prometheus.cli
  • prometheus.doc

GaetanLepage avatar Dec 13 '25 20:12 GaetanLepage