nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

oku: init at 0.1.1

Open ethancedwards8 opened this issue 6 months ago • 3 comments

NLNet Project: https://nlnet.nl/project/Oku/

Closes: https://github.com/ngi-nix/ngipkgs/issues/1156

Things done

  • Built on platform(s)
    • [ ] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ] Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a :+1: reaction to pull requests you find important.

ethancedwards8 avatar Jun 15 '25 00:06 ethancedwards8

This builds correctly, but coredumps when I am running it. I may be holding it wrong though, do you have directions for me to test functionnality ?

JulienMalka avatar Jun 16 '25 14:06 JulienMalka

@julienmalka I've fixed the core dump but the icons are not appearing. Any ideas? I thought the wrapper hook took care of it. Not sure.

ethancedwards8 avatar Jun 23 '25 00:06 ethancedwards8

May be relevant: https://github.com/OkuBrowser/oku/blob/master/BUILDING.md#missing-icon

ethancedwards8 avatar Jun 23 '25 00:06 ethancedwards8

Icons work now... but at what cost

JulienMalka avatar Jun 28 '25 21:06 JulienMalka

Copying a vendored version of hicolor-icons is not great, but I am not sure there is any alternative here. Maybe you could try copying the nixpkgs version, or even better just linking it and see if it still works ?

JulienMalka avatar Jun 29 '25 12:06 JulienMalka

Copying from nixpkgs did not work. I'm afraid we may just have to copy the vendored versions? Try it on your machine maybe?

ethancedwards8 avatar Jun 30 '25 16:06 ethancedwards8

I tried and I was reaching the same conclusion. If you come back to the vendored version I'll merge.

JulienMalka avatar Jun 30 '25 16:06 JulienMalka

Okay. Will do. Thanks!

ethancedwards8 avatar Jun 30 '25 17:06 ethancedwards8