python313Packages.streaming-form-data: 1.13.0 -> 1.19.1
https://github.com/siddhantgoel/streaming-form-data/blob/v1.19.1/CHANGELOG.md
~~This also fixes the build of python313Packages.streaming-form-data (#388196, #356812).~~
Python 3.13 build was fixed separately via https://github.com/NixOS/nixpkgs/commit/18590d1e372a8e4414120da1a0c497e1ed353454.
Things done
- Built on platform(s)
- [x] x86_64-linux
- [x] aarch64-linux
- [x] x86_64-darwin
- [x] aarch64-darwin
- For non-Linux: Is sandboxing enabled in
nix.conf? (See Nix manual)- [ ]
sandbox = relaxed - [x]
sandbox = true
- [ ]
- [x] Tested, as applicable:
- NixOS test(s) (look inside nixos/tests)
- and/or package tests
- or, for functions and "core" functionality, tests in lib/tests or pkgs/test
- made sure NixOS tests are linked to the relevant packages
- [x] Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage - [ ] Tested basic functionality of all binary files (usually in
./result/bin/) -
Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
-
NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.
Add a :+1: reaction to pull requests you find important.
I noticed the package doesn't build on Python 3.10 due to the build of the current version of sphinx, a transitive dependency of requests-toolbelt (which is only required for testing), being disabled for Python 3.10.
What's the usual way to handle this? Disable the build for Python 3.10? Disable the tests for Python 3.10? Or just let the evaluation of python310Packages.streaming-form-data fail when sphinx is tried to be evaluated?
nixpkgs-review result
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 415656
Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/16722863686
x86_64-linux
:white_check_mark: 5 packages built:
- moonraker
- python312Packages.streaming-form-data
- python312Packages.streaming-form-data.dist
- python313Packages.streaming-form-data
- python313Packages.streaming-form-data.dist
aarch64-linux
:white_check_mark: 5 packages built:
- moonraker
- python312Packages.streaming-form-data
- python312Packages.streaming-form-data.dist
- python313Packages.streaming-form-data
- python313Packages.streaming-form-data.dist
x86_64-darwin (sandbox = true)
:white_check_mark: 5 packages built:
- moonraker
- python312Packages.streaming-form-data
- python312Packages.streaming-form-data.dist
- python313Packages.streaming-form-data
- python313Packages.streaming-form-data.dist
aarch64-darwin (sandbox = true)
:white_check_mark: 5 packages built:
- moonraker
- python312Packages.streaming-form-data
- python312Packages.streaming-form-data.dist
- python313Packages.streaming-form-data
- python313Packages.streaming-form-data.dist
Reopen for CI
moonraker tests are also passing just fine. :)
nixpkgs-review result for #415656
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 415656
Commit: 5fb2e04299686399b555cc2492266481a18ad260 (subsequent changes)
Merge: 9eba3fdb64ecaa726fd2f9dd913a2be0e9447eac
Logs: https://github.com/thunze/nixpkgs-review-gha/actions/runs/20192342141
x86_64-linux
:white_check_mark: 5 packages built:
- moonraker
- python312Packages.streaming-form-data
- python312Packages.streaming-form-data.dist
- python313Packages.streaming-form-data
- python313Packages.streaming-form-data.dist
aarch64-linux
:white_check_mark: 5 packages built:
- moonraker
- python312Packages.streaming-form-data
- python312Packages.streaming-form-data.dist
- python313Packages.streaming-form-data
- python313Packages.streaming-form-data.dist
x86_64-darwin (sandbox = relaxed)
:white_check_mark: 5 packages built:
- moonraker
- python312Packages.streaming-form-data
- python312Packages.streaming-form-data.dist
- python313Packages.streaming-form-data
- python313Packages.streaming-form-data.dist
aarch64-darwin (sandbox = relaxed)
:white_check_mark: 5 packages built:
- moonraker
- python312Packages.streaming-form-data
- python312Packages.streaming-form-data.dist
- python313Packages.streaming-form-data
- python313Packages.streaming-form-data.dist