nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

ddnet: 18.4 -> 18.6

Open atemp opened this issue 1 year ago • 2 comments

https://ddnet.org/downloads/#18.6 https://github.com/ddnet/ddnet/compare/18.4...18.6

removed patch (PR https://github.com/ddnet/ddnet/pull/8517 Fix gcc format-security warnings on build) that is not longer needed to compile.

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

atemp avatar Oct 06 '24 18:10 atemp

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 346915


x86_64-linux

:white_check_mark: 2 packages built:
  • ddnet
  • ddnet-server

Scrumplex avatar Oct 20 '24 09:10 Scrumplex

I would suggest that you add yourself as a maintainer to this package as you have been updating it regularly ^^

in the next months will be quite busy, so right now that feels not like a good idea to me (e.g. i had no time to do 18.5)

atemp avatar Oct 22 '24 08:10 atemp