nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

soulseekqt: fixed desktop file

Open dasj19 opened this issue 6 months ago • 0 comments

Description of changes

If installed as-is the package creates a broken desktop file which can be accessed from a DE like Gnome. The .desktop file pointed to the AppImage extracted binary file and was set to open in a terminal.

This PR changes the path to the resulting binary of soulseekqt and disables flag that opened the application in a terminal window.

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

dasj19 avatar Aug 30 '24 13:08 dasj19