nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

circt: 1.83.0 -> 1.84.0

Open sequencer opened this issue 1 year ago • 3 comments

  • circt: 1.83 -> 1.84
  • circt: add sequencer to maintainers

Description of changes

Things done

  • Built on platform(s)
    • [ ] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

sequencer avatar Aug 30 '24 03:08 sequencer

Thanks~

sequencer avatar Aug 30 '24 04:08 sequencer

Result of nixpkgs-review pr 338312 run on x86_64-linux 1

3 packages built:
  • circt
  • circt.dev
  • circt.lib

pineapplehunter avatar Aug 30 '24 09:08 pineapplehunter

result of nixpkgs-review pr 338312 (build on aarch64)

$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/338312/head:refs/nixpkgs-review/1
remote: Enumerating objects: 2132, done.
remote: Counting objects: 100% (1028/1028), done.
remote: Compressing objects: 100% (395/395), done.
Receiving objects: 100% (691/691), 211.05 KiB | 783.00 KiB/s, done.
remote: Total 691 (delta 475), reused 442 (delta 253), pack-reused 0 (from 0)
Resolving deltas: 100% (475/475), completed with 143 local objects.
From https://github.com/NixOS/nixpkgs
 * [new branch]                master                -> refs/nixpkgs-review/0
 * [new ref]                   refs/pull/338312/head -> refs/nixpkgs-review/1
$ git worktree add /home/sequencer/.cache/nixpkgs-review/pr-338312/nixpkgs b956c2f42a5d0c9fbbfd8b2a9cf3bb5f0a6fcf41
Preparing worktree (detached HEAD b956c2f42a5d)
Updating files: 100% (42976/42976), done.
HEAD is now at b956c2f42a5d ocamlPackages.lockfree: 0.4.0 → 0.5.0
$ git merge --no-commit --no-ff 21baffd4052beea8fc8b78415b24cac5528ac94e
Auto-merging maintainers/maintainer-list.nix
Automatic merge went well; stopped before committing as requested
┏━ Dependency Graph:
┃ ✔ review-shell
┣━━━ Builds
┗━ ∑ ⏵ 0 │ ✔ 1 │ ⏸ 0 │ Finished at 20:16:49 after 0s

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/338312

3 packages built:
circt circt.dev circt.lib

$ /etc/profiles/per-user/sequencer/bin/nom-shell --argstr system aarch64-linux --argstr nixpkgs-path /home/sequencer/.cache/nixpkgs-review/pr-338312/nixpkgs --argstr nixpkgs-config-path /tmp/tmp39xsx_dn.nix --argstr attrs-path /home/sequencer/.cache/nixpkgs-review/pr-338312/attrs.nix --nix-path 'nixpkgs=/home/sequencer/.cache/nixpkgs-review/pr-338312/nixpkgs nixpkgs-overlays=/tmp/tmp2gias7bm' /nix/store/31zva50bkbk1cihpzd66jy7aahm6521z-nixpkgs-review-2.10.5/lib/python3.12/site-packages/nixpkgs_review/nix/review-shell.nix

sequencer avatar Aug 30 '24 12:08 sequencer