NixOS
python312Packages.textual: 0.72.0 -> 0.79.0
Description of changes
Things done
- Built on platform(s)
- [ ] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in
nix.conf? (See Nix manual)- [ ]
sandbox = relaxed - [ ]
sandbox = true
- [ ]
- [ ] Tested, as applicable:
- NixOS test(s) (look inside nixos/tests)
- and/or package tests
- or, for functions and "core" functionality, tests in lib/tests or pkgs/test
- made sure NixOS tests are linked to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage - [ ] Tested basic functionality of all binary files (usually in
./result/bin/) - 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits CONTRIBUTING.md.
Add a :+1: reaction to pull requests you find important.
the build failure strikes me as a concurrency issue, consider removing pytest-xdist
Correct. I checked with upstream and they suggest adding the flag I put in with the last edit to force group execution. Some of their tests rely on state from previous tests in the same group.
but it still breaks
Where? I added the group argument and it now passes, because it runs all the related tests from the group in a single thread. The run you linked appears to be from before I added the extra flag, from what I can tell.
https://github.com/NixOS/nixpkgs/pull/333360/checks?check_run_id=29127535637
https://logs.ofborg.org/?key=nixos/nixpkgs.333360&attempt_id=2660e8f1-e1b9-4e3b-a151-1b47d073d621
#333360 (checks) logs.ofborg.org?key=nixos/nixpkgs.333360&attempt_id=2660e8f1-e1b9-4e3b-a151-1b47d073d621
That's from the previous commit where I hadn't added the options, from what I can tell.
Any chance this gets merged soon? I need it for a downstream dependency.
Result of nixpkgs-review pr 333360 run on x86_64-linux 1
4 packages failed to build:
- browsr
- browsr.dist
- textual-paint
- textual-paint.dist
45 packages built:
- dooit
- dooit.dist
- frogmouth
- frogmouth.dist
- memray
- memray.dist
- oterm
- oterm.dist
- python311Packages.graphrag
- python311Packages.graphrag.dist
- python311Packages.manifestoo
- python311Packages.manifestoo.dist
- python311Packages.pytest-textual-snapshot
- python311Packages.pytest-textual-snapshot.dist
- python311Packages.textual
- python311Packages.textual-dev
- python311Packages.textual-dev.dist
- python311Packages.textual-universal-directorytree
- python311Packages.textual-universal-directorytree.dist
- python311Packages.textual.dist
- python312Packages.graphrag
- python312Packages.graphrag.dist
- python312Packages.manifestoo
- python312Packages.manifestoo.dist
- python312Packages.pytest-textual-snapshot
- python312Packages.pytest-textual-snapshot.dist
- python312Packages.textual
- python312Packages.textual-dev
- python312Packages.textual-dev.dist
- python312Packages.textual-universal-directorytree
- python312Packages.textual-universal-directorytree.dist
- python312Packages.textual.dist
- rich-cli
- rich-cli.dist
- smassh
- smassh.dist
- streamcontroller
- tftui
- tftui.dist
- toolong
- toolong.dist
- upiano
- upiano.dist
- wsrepl
- wsrepl.dist
