nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

canaille: init at 0.0.55, add module

Open erictapen opened this issue 1 year ago • 2 comments

Description of changes

The module is already usable and can be deployed as can be seen here: https://canaille.erictapen.name

~~Most of the options are missing currently, and it would be nice to have a working deployment check in the NixOS test.~~

Addresses:

  • https://github.com/ngi-nix/ngipkgs/issues/14
  • https://gitlab.com/yaal/canaille/-/issues/190

~~I'll plan to get this into reviewable shape beginning next week.~~ :heavy_check_mark:

Pinging people involved so far: @azmeuk @Janik-Haag @fricklerhandwerk (@soupglasses because I used parts of your package definition and you seem to be involved)

Things done

  • Built on platform(s)
    • [X] x86_64-linux
    • [X] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

erictapen avatar Aug 08 '24 13:08 erictapen

@dotlambda Do you think you can have a look at this?

erictapen avatar Aug 29 '24 16:08 erictapen

Thanks for the review. I'll squash later to keep the commit messages for now.

erictapen avatar Aug 30 '24 10:08 erictapen

@ofborg build canaille canaille.passthru.tests

wegank avatar Oct 28 '24 21:10 wegank

I just rebased and squashed. Weirdly I couldn't reproduce the build failure and also in the current version it builds on my machine.

erictapen avatar Oct 29 '24 08:10 erictapen

FYI Canaille 0.0.56 has been released.

  • It uses uv+hatchling instead of poetry.
  • It adds a postgresql extra which rely on sqlalchemy[postgresql].

azmeuk avatar Nov 07 '24 13:11 azmeuk

Updated to 0.0.56, should be ready for review again!

erictapen avatar Nov 21 '24 16:11 erictapen

Successfully created backport PR for release-24.11:

  • #358353

github-actions[bot] avatar Nov 23 '24 09:11 github-actions[bot]

Thank you all for your hard work!

azmeuk avatar Nov 23 '24 11:11 azmeuk

Well thanks for your feedback on it :)

erictapen avatar Nov 23 '24 11:11 erictapen

Hi Kerstin @erictapen ! It happens that providing a nix package for Canaille is part of a list of tasks sponsored by NLNet. Since you've done it, they'll need you to reach out to them (I'll send you their contact by email) so you can work out on getting the payment that was routed to this task, they will need your name and address.

Have a nice day !

funelie avatar Dec 19 '24 10:12 funelie

@funelie thanks, this is taken care of, we organise this through Summer of Nix.

fricklerhandwerk avatar Dec 19 '24 11:12 fricklerhandwerk

Hi there.

Just as a curiosity to @funelie, how does these sponsorships get awarded? This PR's nix package is primarily based on my work in another repository https://github.com/soupglasses/phenix/blob/main/nixos/packages/servers/canaille/default.nix

While the NixOS test and NixOS module are new, and its great to get canaille upstream, it feels a bit disappointing that someone gets the NLNet money for a package I created based on copyright infringement (MIT requires the copyright notice to be included in substantial copies of the code). This can also be further seen in the way dependencies are fetched, to the code being character by character the same.

Example 1: https://github.com/soupglasses/phenix/blob/14dd7b40b3194214d312c8b3d9a89ff3a3230f91/nixos/packages/servers/canaille/default.nix#L73-L79

https://github.com/erictapen/nixpkgs/blob/86f19b7908fba61b49f4c8947882ac4fa2f7b813/pkgs/by-name/ca/canaille/package.nix#L69-L74

Example 2: https://github.com/soupglasses/phenix/blob/14dd7b40b3194214d312c8b3d9a89ff3a3230f91/nixos/packages/servers/canaille/default.nix#L81-L84

https://github.com/erictapen/nixpkgs/blob/86f19b7908fba61b49f4c8947882ac4fa2f7b813/pkgs/by-name/ca/canaille/package.nix#L64-L67

soupglasses avatar Dec 19 '24 22:12 soupglasses

Hi @soupglasses, I will allow myself to answer you in place of @funelie who is not available at the moment. I am sorry to hear of your disappointment and I understand your situation. Unfortunately, in your case, I can only advise you to contact NLnet for all your questions. https://nlnet.nl/

Indeed, they are the ones who define and manage this funding. In addition, it seems that this functionality has already given rise to a payment. Since redistribution is no longer relevant, our role ends here.

I sincerely hope that you will receive a satisfactory response from NLnet.

Kind regards.

SbirLobo avatar Dec 20 '24 10:12 SbirLobo