nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

ytmdesktop: init at 2.0.5

Open cjshearer opened this issue 1 month ago • 4 comments

Description of changes

Restores ytmdesktop, a desktop app for Youtube Music. It was previously removed due to missing source. This also expands support to all electron platforms, with the exception of darwin, since I don't have a way to test that and the installation process is slightly different (see my comment above meta.badPlatforms for more info).

Note that commandLineArgs are passed from the derivation inputs, enabling a consumer to override it and set a default CLI flag. This is useful for setting values like --password-store="gnome-libsecret", which is sometimes necessary to overcome safeStorage detection outside of predefined desktop environments.

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cjshearer avatar Jun 04 '24 22:06 cjshearer