nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

dosbox-staging: 0.80.1 -> 0.81.1

Open JohnRTitor opened this issue 1 year ago • 7 comments

Description of changes

  • Closes https://github.com/NixOS/nixpkgs/issues/293911
  • remove patches that are now upstream

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

JohnRTitor avatar May 10 '24 19:05 JohnRTitor

Result of nixpkgs-review pr 310664 run on x86_64-linux 1

1 package built:
  • dosbox-staging

keenanweaver avatar May 10 '24 21:05 keenanweaver

0.81.1 is now out: https://github.com/dosbox-staging/dosbox-staging/releases/tag/v0.81.1

keenanweaver avatar May 12 '24 14:05 keenanweaver

I believe 0.81.0 includes support for using zlib-ng during video capture for improved performance, so that should probably be included as a dependency now.

romatthe avatar May 13 '24 11:05 romatthe

Done. Thanks.

JohnRTitor avatar May 13 '24 11:05 JohnRTitor

Another minor note: when I was building 0,81.0 myself a few days ago, I noticed that the version string in several locations was incorrect. See https://github.com/dosbox-staging/dosbox-staging/issues/3521#issuecomment-2103626719

Not sure if this is still an issue in 0.81.1 (at work atm) or if this is even worth trying to correct, but I figured I'd mention it.

romatthe avatar May 13 '24 11:05 romatthe

image

Looks fine on my end.

JohnRTitor avatar May 13 '24 12:05 JohnRTitor

Result of nixpkgs-review pr 310664 run on x86_64-linux 1

1 package built:
  • dosbox-staging

keenanweaver avatar May 13 '24 21:05 keenanweaver