nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

hmcl: 3.5.5 -> 3.5.7

Open Daru-san opened this issue 1 year ago • 4 comments

Description of changes

Update hmcl package to 3.5.7 and add myself as a maintainer since there are none currently

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Daru-san avatar May 09 '24 18:05 Daru-san

For some odd reason it keeps failing with this error, I don't know why as of yet though

       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > no configure script, doing nothing
       > Running phase: buildPhase
       > no Makefile or custom buildPhase, doing nothing
       > Running phase: glibPreInstallPhase
       > Running phase: glibPreInstallPhase
       > Running phase: installPhase
       > install: cannot stat 'hmcl.png': No such file or directory
       For full logs, run 'nix log /nix/store/frawz1jl6d8zjycpk6740gl9xfrczg5d-hmcl-3.5.7.drv'.

Daru-san avatar May 10 '24 04:05 Daru-san

Result of nixpkgs-review pr 310403 run on x86_64-linux 1

1 package failed to build:
  • hmcl

pluiedev avatar May 10 '24 06:05 pluiedev

install: cannot stat 'hmcl.png': No such file or directory

The call to imagemagick is producing multiple hmcl-*.png files, as the icon file contains multiple images (presumably the same at multiple resolutions)

nicoonoclaste avatar May 13 '24 09:05 nicoonoclaste

Thanks for the review, I realised what was wrong and now it builds successfully

Daru-san avatar May 14 '24 03:05 Daru-san