nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

Published 20 hours ago • verified publisher icon NixOS

platformsh: 4.17.0 -> 5.0.12

Open trsteel88 opened this issue 9 months ago • 2 comments

Description of changes

Remove the deprecated legacy cli in favor of the new version.

Things done

This script is a copy of the Upsun CLI package which is released under the same repository.

I have modified the binary to use platform instead of upsun

trsteel88 avatar May 07 '24 00:05 trsteel88

Also is it not possible to be built from source now? I prefer to wait longer to see if there is a solution.

its still complicated build at the moment using docker buildx. If possible I think we should try to have platformsh cli updated because we are migrating new features there

spk avatar May 13 '24 11:05 spk

Also why is @shyim removed from maintainers?

Aleksanaa avatar May 14 '24 03:05 Aleksanaa

Also why is @shyim removed from maintainers?

Sorry, fixed this.

trsteel88 avatar May 16 '24 10:05 trsteel88

maybe commits can be squashed to platformsh: 4.17.0 -> 5.0.13

spk avatar May 17 '24 12:05 spk

Okay

Aleksanaa avatar May 17 '24 12:05 Aleksanaa

It doesn't build on Hydra now: https://hydra.nixos.org/eval/1806362?filter=platformsh#tabs-now-fail

vcunat avatar May 18 '24 06:05 vcunat

@trsteel88 are you fixing it? Otherwise I'll fix it

Aleksanaa avatar May 18 '24 06:05 Aleksanaa

@trsteel88 are you fixing it? Otherwise I'll fix it

Was just looking at it and it is because the binary is called "platform" rather than "platformsh". I'm not sure what needs to be adjusted to fix this.

Is it line 42 and line 50?

trsteel88 avatar May 18 '24 06:05 trsteel88

I am creating a PR to fix it

shyim avatar May 18 '24 07:05 shyim

@shyim thanks for sorting that. I am new to nix but wondering how updates get delivered. e.g. 5.0.14 has been released. Does someone have to come into this repository and update the version and hashes on https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/pl/platformsh/package.nix each time a new release comes out?

If that's correct it is very manual - is there a way to automate this?

trsteel88 avatar Jun 04 '24 01:06 trsteel88

There's a bot that can detect updates for some kinds of packages and open pull requests: https://github.com/NixOS/nixpkgs/pulls/r-ryantm

vcunat avatar Jun 04 '24 07:06 vcunat

The better way would we if we provide a update script, so we can run it also locally 🤔

shyim avatar Jun 04 '24 07:06 shyim

The bot uses those update scripts, too.

vcunat avatar Jun 04 '24 07:06 vcunat

Look like the bot is using https://repology.org/project/platformsh/versions but since the package is not on any distributions (beside nixos) it fails to fetch the latest one?

spk avatar Jun 04 '24 09:06 spk

Yes, repology is used, but if you provide an update script, it should be used instead AFAIK: https://nix-community.github.io/nixpkgs-update/batch-updates/#batch-updates

vcunat avatar Jun 04 '24 09:06 vcunat