nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

seabird: init at 0.2.1

Open nicolas-goudry opened this issue 1 year ago • 3 comments

Description of changes

Graphical Kubernetes desktop client: https://getseabird.github.io

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [ ] Tested, as applicable:
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nicolas-goudry avatar Mar 01 '24 13:03 nicolas-goudry

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3547

nixos-discourse avatar Mar 01 '24 15:03 nixos-discourse

Updated PR to init at 0.2.1 (just released).

diff --git a/pkgs/by-name/se/seabird/package.nix b/pkgs/by-name/se/seabird/package.nix
index a3fab66d59f4..fcf5175e3aeb 100644
--- a/pkgs/by-name/se/seabird/package.nix
+++ b/pkgs/by-name/se/seabird/package.nix
@@ -15,16 +15,16 @@
 
 buildGo122Module rec {
   pname = "seabird";
-  version = "0.1.2";
+  version = "0.2.1";
 
   src = fetchFromGitHub {
     owner = "getseabird";
     repo = "seabird";
     rev = "v${version}";
-    hash = "sha256-jPdAKdRHdtxCzgv5nIf3FUyGS+0tOz8idg2B19uX5cg=";
+    hash = "sha256-wEZS5wOiSaCJ5jEx5tfp6QxY0SgwP5e7MV+iqekHmPY=";
   };
 
-  vendorHash = "sha256-n/KQAThQ8aft5dlHefMZxK2/EUnfXXJfynqHNiBZrnE=";
+  vendorHash = "sha256-z9l6g5NkAErRQo8oiqwKG9ssm8K2S+eSZBD0w4kO3kc=";
 
   nativeBuildInputs = [
     copyDesktopItems

@OmnipotentEntity @valentin-ricard Would you be kind enough to test this again? Thanks!

nicolas-goudry avatar Mar 03 '24 12:03 nicolas-goudry

But I have taken a look at the "About" section, but "dev" is set to the version number.

Nice catch, it’s now fixed.

nicolas-goudry avatar Mar 03 '24 16:03 nicolas-goudry

Updated PR to init at 0.2.2 (released last week). Removed glib from nativeBuildInputs. Added glibc to buildInputs.


Result of nixpkgs-review pr 292581 run on x86_64-linux 1

1 package built:
  • seabird

nicolas-goudry avatar Mar 09 '24 11:03 nicolas-goudry

Replaced (invalid) install phase by postInstall hook. Also fixed invalid icon filename.


Result of nixpkgs-review pr 292581 run on x86_64-linux 1

1 package built:
  • seabird

nicolas-goudry avatar Mar 09 '24 15:03 nicolas-goudry

Result of nixpkgs-review pr 292581 run on aarch64-darwin 1

1 package built:
  • seabird

wegank avatar Mar 09 '24 21:03 wegank