NixOS
python3Packages.mediafile: 0.10.1 -> 0.12.0
Description of changes
Updated from 0.10.1 to 0.12.0 Mediafile changelog:
v0.12.0 Add the multiple-valued properties artists_credit, artists_sort, albumartists_credit, and albumartists_sort. v0.11.0 List-valued properties now return None instead of an empty list when the underlying tags are missing altogether.
Things done
- Built on platform(s)
- [x] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in
nix.conf? (See Nix manual)- [ ]
sandbox = relaxed - [ ]
sandbox = true
- [ ]
- [ ] Tested, as applicable:
- NixOS test(s) (look inside nixos/tests)
- and/or package tests
- or, for functions and "core" functionality, tests in lib/tests or pkgs/test
- made sure NixOS tests are linked to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage - [ ] Tested basic functionality of all binary files (usually in
./result/bin/) - 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits CONTRIBUTING.md.
Add a :+1: reaction to pull requests you find important.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3556
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 291184 run on x86_64-linux 1
1 package failed to build and already failed to build on hydra master:
- python312Packages.pyatv: plain log
13 packages failed to build and are new build failures:
- beets: plain log
- (beetsPackages.beets: log was empty
- ,beetsPackages.beets-stable): log was empty
- ,beetsPackages.beets.man): log was empty
21 packages built:
- beets-unstable (beetsPackages.beets-unstable)
- beets-unstable.dist (beetsPackages.beets-unstable.dist)
- beets-unstable.doc (beetsPackages.beets-unstable.doc)
- beets-unstable.man (beetsPackages.beets-unstable.man)
- beetsPackages.alternatives
- beetsPackages.alternatives.dist
- beetsPackages.beets-minimal
- beetsPackages.beets-minimal.dist
- beetsPackages.beets-minimal.doc
- beetsPackages.beets-minimal.man
- beetsPackages.copyartifacts
- beetsPackages.copyartifacts.dist
- beetsPackages.extrafiles
- beetsPackages.extrafiles.dist
- home-assistant-component-tests.apple_tv
- python311Packages.mediafile
- python311Packages.mediafile.dist
- python311Packages.pyatv
- python311Packages.pyatv.dist
- python312Packages.mediafile
- python312Packages.mediafile.dist
The following issues got detected with the above build packages. Please fix at least the ones listed with your changed packages:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
got build log for '/nix/store/c669rz6d8f165m974hilhhih7nrsvdda-beets-1.6.0-dist' from 'daemon'
When evaluating attribute ‘beetsPackages.beets-minimal.dist’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
got build log for '/nix/store/7388jcjnj9a2m810mqcwq58l9gsk73ly-beets-1.6.0-doc' from 'daemon'
When evaluating attribute ‘beetsPackages.beets-minimal.doc’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
got build log for '/nix/store/amv8h824g4lazkpnx8i35jj63gyj842k-beets-1.6.0' from 'daemon'
When evaluating attribute ‘beetsPackages.beets-minimal’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
got build log for '/nix/store/jpl2q1xkx5vacc19j6arrhdxplwx3qhq-beets-1.6.0-man' from 'daemon'
When evaluating attribute ‘beetsPackages.beets-minimal.man’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
Package is missing maintainers. If the package is using runCommand please make sure to inherit or list one or more maintainers.
Package is missing maintainers. If the package is using runCommand please make sure to inherit or list one or more maintainers.
Package is missing maintainers. If the package is using runCommand please make sure to inherit or list one or more maintainers.
Package is missing maintainers. If the package is using runCommand please make sure to inherit or list one or more maintainers.
got build log for '/nix/store/1wryl1kr0b2nqrdyvzzcdhb1dxjwss6g-beets-unstable-2023-10-26-dist' from 'daemon'
When evaluating attribute ‘beets-unstable.dist’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
got build log for '/nix/store/i875890bf3pd59prcl957nhyn4lbgxn8-beets-unstable-2023-10-26-doc' from 'daemon'
When evaluating attribute ‘beets-unstable.doc’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
got build log for '/nix/store/ji425ck0bjpvf49w2vw5if8m2vd3wm6i-beets-unstable-2023-10-26' from 'daemon'
When evaluating attribute ‘beets-unstable’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
got build log for '/nix/store/n09gygxqivv26b9m09ifm2926wn1h536-beets-unstable-2023-10-26-man' from 'daemon'
When evaluating attribute ‘beets-unstable.man’:
warning: unused-argument
Unused argument: stdenv.
Near pkgs/tools/audio/beets/common.nix:1:3:
|
1 | { stdenv
| ^
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/tools/audio/beets/common.nix:2:3:
|
2 | , fetchpatch
| ^
warning: unused-argument
Unused argument: glibcLocales.
Near pkgs/tools/audio/beets/common.nix:5:3:
|
5 | , glibcLocales
| ^
warning: unused-argument
Unused argument: aacgain.
Near pkgs/tools/audio/beets/common.nix:15:3:
|
15 | , aacgain
| ^
warning: unused-argument
Unused argument: essentia-extractor.
Near pkgs/tools/audio/beets/common.nix:16:3:
|
16 | , essentia-extractor
| ^
warning: unused-argument
Unused argument: ffmpeg.
Near pkgs/tools/audio/beets/common.nix:17:3:
|
17 | , ffmpeg
| ^
warning: unused-argument
Unused argument: flac.
Near pkgs/tools/audio/beets/common.nix:18:3:
|
18 | , flac
| ^
warning: unused-argument
Unused argument: imagemagick.
Near pkgs/tools/audio/beets/common.nix:19:3:
|
19 | , imagemagick
| ^
warning: unused-argument
Unused argument: keyfinder-cli.
Near pkgs/tools/audio/beets/common.nix:20:3:
|
20 | , keyfinder-cli
| ^
warning: unused-argument
Unused argument: mp3gain.
Near pkgs/tools/audio/beets/common.nix:21:3:
|
21 | , mp3gain
| ^
warning: unused-argument
Unused argument: mp3val.
Near pkgs/tools/audio/beets/common.nix:22:3:
|
22 | , mp3val
| ^
This update breaks beets tests
beets> ________________________ ZeroPluginTest.test_album_art _________________________
beets>
beets> self = <test.test_zero.ZeroPluginTest testMethod=test_album_art>
beets>
beets> def test_album_art(self):
beets> self.config['zero']['fields'] = ['images']
beets>
beets> path = self.create_mediafile_fixture(images=['jpg'])
beets> item = Item.from_path(path)
beets>
beets> self.load_plugins('zero')
beets> item.write()
beets>
beets> mf = MediaFile(syspath(path))
beets> > self.assertEqual(0, len(mf.images))
beets> E TypeError: object of type 'NoneType' has no len()
beets>
beets> test/test_zero.py:106: TypeError
This update breaks beets tests ...
Thank you for reviewing! I seem to have missed some steps in properly validating this PR. I will modify this PR to update beets as well and perform the proper validation for both packages.
Fixed the issue, was getting beets and beets-unstable mixed up, realized it was just that the stable beets version (which is very old at this point) was incompatible with the mediafile update. I pinned the stable to 0.10.1.
Result of nixpkgs-review pr 291184 run on x86_64-linux 1
27 packages built:
- beets (beetsPackages.beets ,beetsPackages.beets-stable)
- beets-unstable (beetsPackages.beets-unstable)
- beets-unstable.dist (beetsPackages.beets-unstable.dist)
- beets-unstable.doc (beetsPackages.beets-unstable.doc)
- beets-unstable.man (beetsPackages.beets-unstable.man)
- beets.dist (beetsPackages.beets-stable.dist ,beetsPackages.beets.dist)
- beets.doc (beetsPackages.beets-stable.doc ,beetsPackages.beets.doc)
- beets.man (beetsPackages.beets-stable.man ,beetsPackages.beets.man)
- beetsPackages.alternatives
- beetsPackages.alternatives.dist
- beetsPackages.beets-minimal
- beetsPackages.beets-minimal.dist
- beetsPackages.beets-minimal.doc
- beetsPackages.beets-minimal.man
- beetsPackages.copyartifacts
- beetsPackages.copyartifacts.dist
- beetsPackages.extrafiles
- beetsPackages.extrafiles.dist
- home-assistant-component-tests.apple_tv
- python311Packages.mediafile
- python311Packages.mediafile.dist
- python311Packages.pyatv
- python311Packages.pyatv.dist
- python312Packages.mediafile
- python312Packages.mediafile.dist
- python312Packages.pyatv
- python312Packages.pyatv.dist
Building beets-extrafiles (https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/tools/audio/beets/plugins/extrafiles.nix) as a plugin to beets is now broken as far as I understand:
error: builder for '/nix/store/9bpavjz02ja94i4lmqwlldwm7dpq8gqg-beets-1.6.0.drv' failed with exit code 1;
last 10 log lines:
> dependency chain:
> this derivation: /nix/store/klijbhfx19v9r50p9lxgr7dz7sjlzxp6-beets-1.6.0
> ...depending on: /nix/store/kbj7yargkxgpqx7m4wg8sx2mpkjkz6rs-python3.11-mediafile-0.10.1
> mediafile 0.12.0 (/nix/store/ss4zs44dc48clwnfq0s0lrp7d2fr02zf-python3.11-mediafile-0.12.0)
> dependency chain:
> this derivation: /nix/store/klijbhfx19v9r50p9lxgr7dz7sjlzxp6-beets-1.6.0
> ...depending on: /nix/store/8p94qw89gxs6hlhin6nwwb33hh0x3mjz-beets-extrafiles-unstable-2020-12-13
> ...depending on: /nix/store/ss4zs44dc48clwnfq0s0lrp7d2fr02zf-python3.11-mediafile-0.12.0
>
> Package duplicates found in closure, see above. Usually this happens if two packages depend on different version of the same dependency.
For full logs, run 'nix log /nix/store/9bpavjz02ja94i4lmqwlldwm7dpq8gqg-beets-1.6.0.drv'.
error: 1 dependencies of derivation '/nix/store/66fnglghryamfww6zhhjibc0a1ld8pqq-beets-1.6.0-fish-completions.drv' failed to build
error: 1 dependencies of derivation '/nix/store/378ga8kwj98k1b1mz5hf5sq53zrzf8ha-home-manager-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/ih93vk1hhjq2b4wfypjr2if9qh8nxw02-man-paths.drv' failed to build
error: 1 dependencies of derivation '/nix/store/fzw4h5gl6qs4l627vggffhd9fn1270ri-home-manager-generation.drv' failed to build
error: 1 dependencies of derivation '/nix/store/aiqvh48yphw83iwsqcv9jj4q4z0giphl-user-environment.drv' failed to build
error: 1 dependencies of derivation '/nix/store/w5sppqg481ypzfb5v2n4kr4ygzb4g43i-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/417wv7d58si0mbcihh385cj1f3fb9y3h-nixos-system-galatea-24.05.20240318.e367f7a.drv' failed to build
This is while building beets this way:
programs.beets = {
enable = true;
package = pkgs.beets.override {
pluginOverrides = {
alternatives = {
enable = true;
propagatedBuildInputs = [ pkgs.beetsPackages.alternatives ];
};
copyartifacts = {
enable = true;
propagatedBuildInputs = [ pkgs.beetsPackages.copyartifacts ];
};
extrafiles = {
enable = true;
propagatedBuildInputs = [ pkgs.beetsPackages.extrafiles ];
};
};
};
# ...
};
For full logs, run 'nix log /nix/store/9bpavjz02ja94i4lmqwlldwm7dpq8gqg-beets-1.6.0.drv'.
Please always post the relevant parts of the full log. Just posting the summary often cuts of important pieces.