nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

kavita: 0.7.1.4 -> 0.7.13

Open melvyn2 opened this issue 2 years ago • 6 comments

Description of changes

https://github.com/Kareadita/Kavita/releases/tag/v0.7.12 https://github.com/Kareadita/Kavita/releases/tag/v0.7.13

Also imported configuration changes from #263649, including switching to freeform settings.

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [x] Tested, as applicable:
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [x] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

melvyn2 avatar Jan 15 '24 23:01 melvyn2

I probably should have searched for these before I submitted another PR, oops. Yours seems to have a lot more fixes, but if you want it superseded I can cherry pick your changes.

melvyn2 avatar Jan 21 '24 20:01 melvyn2

Seeing that you added yourself as a maintainer it might make more sense just to update the previous PR and get it merged, however.

melvyn2 avatar Jan 21 '24 20:01 melvyn2

Note: https://github.com/Kareadita/Kavita/releases/tag/v0.7.13 is latest

luzpaz avatar Jan 24 '24 12:01 luzpaz

Changes seem OK, still needs release notes mention.

nevivurn avatar Jan 26 '24 20:01 nevivurn

Rebased to solve the merge conflict

melvyn2 avatar Jan 29 '24 18:01 melvyn2

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1498

nixos-discourse avatar Mar 04 '24 16:03 nixos-discourse

Tests should be passing now, after all these messy pushes.

melvyn2 avatar Mar 27 '24 04:03 melvyn2