nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

gradle: add package tests

Open liff opened this issue 2 years ago • 5 comments

Description of changes

Add simple package tests for Gradle.

Things done

  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • [x] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

liff avatar Dec 29 '23 12:12 liff

@lorenzleutgeb sorry to bother, but pinging in case you have time to take a peek.

liff avatar Feb 01 '24 13:02 liff

@liff I am on vacation until incl. 2024-02-12. I like the change but don't count on me testing it before then, sorry.

lorenzleutgeb avatar Feb 01 '24 13:02 lorenzleutgeb

Oh even more sorry I bothered you then, have a great rest of your vacation!

liff avatar Feb 01 '24 14:02 liff

Is this good to approve?

liff avatar Mar 03 '24 14:03 liff

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1497

nixos-discourse avatar Mar 04 '24 12:03 nixos-discourse