nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

ruffle: nightly-2022-02-02 -> nightly-2022-09-26

Open jchv opened this issue 1 year ago • 0 comments

Description of changes

Although there isn't a changelog for Ruffle, quite a lot has improved since last nightly, including the beginnings of AVM3 support.

We now need a valid JRE (only during build, to run the ActionScript compiler) and for ruffle desktop, GTK+3. In order to avoid unnecessarily wrapping every binary, and also to avoid double-wrapping, wrapGAppsHook is used with dontWrapGApps = true, then we use "''${gappsWrapperArgs[@]}" in the existing call to wrapProgram for ruffle_desktop. We need the file dialog schemas, so gsettings-desktop-schemas is added to nativeBuildInputs. We need the glib hook that adds schemas to the XDG_CONFIG_PATH, so glib is added to nativeBuildInputs, and postInstall is changed to postFixup to ensure that gappsWrapperArgs is set for us.

I believe this is the minimal necessary changes to make sure that it will work properly.

Things done
  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [x] Tested, as applicable:
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
    • [ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • [x] Fits CONTRIBUTING.md.

jchv avatar Sep 26 '22 07:09 jchv