nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

wxgtk32: init at 3.2.1

Open tfmoraes opened this issue 1 year ago • 4 comments

Description of changes

Add wxwidgets 3.2.1 and Fixes #190946

Things done
  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested, as applicable:
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
    • [ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • [ ] Fits CONTRIBUTING.md.

tfmoraes avatar Sep 18 '22 02:09 tfmoraes

The only package that uses wxgtk-gtk2 that I found is audacity-gtk2, but audacity-gtk3 works too. If there isn't any problem, I think it's better to remove audacity-gtk2 and remove wxgtk-gtk2.

tfmoraes avatar Sep 20 '22 18:09 tfmoraes

The only package that uses wxgtk-gtk2 that I found is audacity-gtk2, but audacity-gtk3 works too. If there isn't any problem, I think it's better to remove audacity-gtk2 and remove wxgtk-gtk2.

Agreed, we should try to move away from any gtk2-based packages. Because of that I think not including gtk2 support in this newer version is preferable.

IvarWithoutBones avatar Sep 20 '22 21:09 IvarWithoutBones

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1210

nixos-discourse avatar Sep 26 '22 07:09 nixos-discourse

I think it's better to remove audacity-gtk2 and remove wxgtk-gtk2.

Yes, please, I don't think we need to introduce a new gtk2 package at all.

SuperSandro2000 avatar Sep 26 '22 09:09 SuperSandro2000

I removed the gtk2 from wxwidgets 3.2

tfmoraes avatar Sep 26 '22 20:09 tfmoraes

Used in #190587 to build wxPython 4.2 for meerk40t. Thanks for the work so far!

mweinelt avatar Sep 28 '22 23:09 mweinelt

@ofborg build wxGTK32

SuperSandro2000 avatar Sep 29 '22 09:09 SuperSandro2000

Thanks 💛

SuperSandro2000 avatar Oct 01 '22 20:10 SuperSandro2000