nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

Published 20 hours ago • verified publisher icon NixOS

tandoor-recipes: init at 1.4.1

Open ambroisie opened this issue 1 year ago • 11 comments

Description of changes

Closes #145244.

A whole lot of python packages that were added to get this working. django-autocomplete-light has been marked doCheck = false to avoid having to package half a dozen more just for its tests.

The frontend does not make use of mkYarnPackage, because of the following issue.

Things done
  • Built on platform(s)
    • [X] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [X] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [X] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [X] (Module addition) Added a release notes entry if adding a new NixOS module
    • [X] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • [X] Fits CONTRIBUTING.md.

ambroisie avatar Sep 16 '22 17:09 ambroisie

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1196

nixos-discourse avatar Sep 17 '22 16:09 nixos-discourse

@SuperSandro2000 addressed all your comments.

ambroisie avatar Sep 17 '22 19:09 ambroisie

nixpkgs-review 

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/191532

1 package failed to build:
baserow

98 packages built:
mailman-web manim netbox paperless-ngx python310Packages.bleach-allowlist python310Packages.deal python310Packages.dj-rest-auth python310Packages.django-annoying python310Packages.django-autocomplete-light python310Packages.django-celery-beat python310Packages.django-cors-headers python310Packages.django-crispy-forms python310Packages.django-graphiql-debug-toolbar python310Packages.django-hcaptcha python310Packages.django-js-reverse python310Packages.django-modelcluster python310Packages.django-oauth-toolkit python310Packages.django-rest-auth python310Packages.django-rest-polymorphic python310Packages.django-scopes python310Packages.django-taggit python310Packages.django-timezone-field python310Packages.djangorestframework python310Packages.djangorestframework-camel-case python310Packages.djangorestframework-dataclasses python310Packages.djangorestframework-guardian python310Packages.djangorestframework-recursive python310Packages.djangorestframework-simplejwt python310Packages.drf-jwt python310Packages.drf-nested-routers python310Packages.drf-spectacular python310Packages.drf-writable-nested python310Packages.drf-yasg python310Packages.extruct python310Packages.graphene-django python310Packages.html-text python310Packages.icontract python310Packages.jstyleson python310Packages.jupyterlab python310Packages.jupyterlab-git python310Packages.jupyterlab-lsp python310Packages.jupyterlab_server python310Packages.jupytext python310Packages.language-tags python310Packages.mf2py python310Packages.microdata python310Packages.openapi-core python310Packages.pyrdfa3 python310Packages.recipe-scrapers python310Packages.vaa python39Packages.bleach-allowlist python39Packages.deal python39Packages.dj-rest-auth python39Packages.django-annoying python39Packages.django-autocomplete-light python39Packages.django-celery-beat python39Packages.django-cors-headers python39Packages.django-crispy-forms python39Packages.django-graphiql-debug-toolbar python39Packages.django-hcaptcha python39Packages.django-js-reverse python39Packages.django-modelcluster python39Packages.django-oauth-toolkit python39Packages.django-rest-auth python39Packages.django-rest-polymorphic python39Packages.django-scopes python39Packages.django-taggit python39Packages.django-timezone-field python39Packages.djangorestframework python39Packages.djangorestframework-camel-case python39Packages.djangorestframework-dataclasses python39Packages.djangorestframework-guardian python39Packages.djangorestframework-recursive python39Packages.djangorestframework-simplejwt python39Packages.drf-jwt python39Packages.drf-nested-routers python39Packages.drf-spectacular python39Packages.drf-writable-nested python39Packages.drf-yasg python39Packages.extruct python39Packages.graphene-django python39Packages.html-text python39Packages.icontract python39Packages.jstyleson python39Packages.jupyterlab python39Packages.jupyterlab-git python39Packages.jupyterlab-lsp python39Packages.jupyterlab_server python39Packages.jupytext python39Packages.language-tags python39Packages.mf2py python39Packages.microdata python39Packages.openapi-core python39Packages.pyrdfa3 python39Packages.recipe-scrapers python39Packages.vaa seahub tandoor-recipes

NobbZ avatar Sep 18 '22 07:09 NobbZ

baserow fails to build in nixpkgs-review because it can't find uvloop. This is also happening on the base of my branch, without any of the commits in this PR, and is not related to my changes.

ambroisie avatar Sep 18 '22 08:09 ambroisie

@SuperSandro2000 @NobbZ friendly ping :-).

ambroisie avatar Sep 20 '22 13:09 ambroisie

I have added the module, still need to add it to the documentation.

Edit: done.

ambroisie avatar Sep 23 '22 12:09 ambroisie

The commit messages are not quite right. For example pythonPackages: django-annoying: init at 0.10.6 should be python310Packages.django-annoying: init at 0.10.6 to trigger ofborg.

SuperSandro2000 avatar Sep 23 '22 16:09 SuperSandro2000

@SuperSandro2000 renamed the commits in accordance with your suggestion.

ambroisie avatar Sep 24 '22 17:09 ambroisie

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 191532 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
4 packages failed to build and already failed to build on hydra master:
  • baserow: log was empty
  • mailman-web: log was empty
  • netbox: log was empty
  • paperless-ngx: log was empty
4 packages failed to build and are new build failures:
  • manim: plain log
  • python310Packages.recipe-scrapers: plain log
  • python39Packages.recipe-scrapers: plain log
  • tandoor-recipes: log was empty
91 packages built:
  • python310Packages.bleach-allowlist
  • python310Packages.deal
  • python310Packages.dj-rest-auth
  • python310Packages.django-annoying
  • python310Packages.django-autocomplete-light
  • python310Packages.django-celery-beat
  • python310Packages.django-cors-headers
  • python310Packages.django-crispy-forms
  • python310Packages.django-graphiql-debug-toolbar
  • python310Packages.django-hcaptcha
  • python310Packages.django-js-reverse
  • python310Packages.django-modelcluster
  • python310Packages.django-oauth-toolkit
  • python310Packages.django-rest-auth
  • python310Packages.django-rest-polymorphic
  • python310Packages.django-scopes
  • python310Packages.django-taggit
  • python310Packages.django-timezone-field
  • python310Packages.djangorestframework
  • python310Packages.djangorestframework-camel-case
  • python310Packages.djangorestframework-dataclasses
  • python310Packages.djangorestframework-guardian
  • python310Packages.djangorestframework-recursive
  • python310Packages.djangorestframework-simplejwt
  • python310Packages.drf-jwt
  • python310Packages.drf-nested-routers
  • python310Packages.drf-spectacular
  • python310Packages.drf-writable-nested
  • python310Packages.drf-yasg
  • python310Packages.extruct
  • python310Packages.graphene-django
  • python310Packages.html-text
  • python310Packages.icontract
  • python310Packages.jstyleson
  • python310Packages.jupyterlab
  • python310Packages.jupyterlab-git
  • python310Packages.jupyterlab-lsp
  • python310Packages.jupyterlab_server
  • python310Packages.jupytext
  • python310Packages.language-tags
  • python310Packages.mf2py
  • python310Packages.microdata
  • python310Packages.openapi-core
  • python310Packages.pyrdfa3
  • python310Packages.vaa
  • python39Packages.bleach-allowlist
  • python39Packages.deal
  • python39Packages.dj-rest-auth
  • python39Packages.django-annoying
  • python39Packages.django-autocomplete-light
  • python39Packages.django-celery-beat
  • python39Packages.django-cors-headers
  • python39Packages.django-crispy-forms
  • python39Packages.django-graphiql-debug-toolbar
  • python39Packages.django-hcaptcha
  • python39Packages.django-js-reverse
  • python39Packages.django-modelcluster
  • python39Packages.django-oauth-toolkit
  • python39Packages.django-rest-auth
  • python39Packages.django-rest-polymorphic
  • python39Packages.django-scopes
  • python39Packages.django-taggit
  • python39Packages.django-timezone-field
  • python39Packages.djangorestframework
  • python39Packages.djangorestframework-camel-case
  • python39Packages.djangorestframework-dataclasses
  • python39Packages.djangorestframework-guardian
  • python39Packages.djangorestframework-recursive
  • python39Packages.djangorestframework-simplejwt
  • python39Packages.drf-jwt
  • python39Packages.drf-nested-routers
  • python39Packages.drf-spectacular
  • python39Packages.drf-writable-nested
  • python39Packages.drf-yasg
  • python39Packages.extruct
  • python39Packages.graphene-django
  • python39Packages.html-text
  • python39Packages.icontract
  • python39Packages.jstyleson
  • python39Packages.jupyterlab
  • python39Packages.jupyterlab-git
  • python39Packages.jupyterlab-lsp
  • python39Packages.jupyterlab_server
  • python39Packages.jupytext
  • python39Packages.language-tags
  • python39Packages.mf2py
  • python39Packages.microdata
  • python39Packages.openapi-core
  • python39Packages.pyrdfa3
  • python39Packages.vaa
  • seahub

The following issues got detected with the above build packages. Please fix at least the ones listed with your changed packages:

baserow:

warning: duplicate-check-inputs Dependencies listed in propagatedBuildInputs should not be repeated in checkInputs.

Detected duplicates:

  • python3.10-boto3-1.24.42

Near pkgs/servers/baserow/default.nix:94:3:

   |
94 |   checkInputs = [
   |   ^

Near pkgs/servers/baserow/default.nix:51:3:

   |
51 |   propagatedBuildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/duplicate-check-inputs.md

python310Packages.django-cors-headers:

got build log for '/nix/store/pf33m4lgdx0h1sk8qs7i09r08nxwmqjb-python3.10-django-cors-headers-3.13.0' from 'daemon' When evaluating attribute ‘python310Packages.django-cors-headers’: warning: maintainers-missing Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/django-cors-headers/default.nix:33:5:

   |
33 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python310Packages.django-scopes:

got build log for '/nix/store/vx2wqcshg4khcvdhdqi661lgwknv2l2a-python3.10-django-scopes-1.2.0.post1' from 'daemon' When evaluating attribute ‘python310Packages.django-scopes’: warning: unused-argument Unused argument: fetchpatch. Near pkgs/development/python-modules/django-scopes/default.nix:3:3:

  |
3 | , fetchpatch
  |   ^

warning: unused-argument Unused argument: coverage. Near pkgs/development/python-modules/django-scopes/default.nix:7:3:

  |
7 | , coverage
  |   ^
python310Packages.drf-yasg:

got build log for '/nix/store/9sl2af6wq57ibk3abpph7jsrn8ncf6j4-python3.10-drf-yasg-1.21.3' from 'daemon' When evaluating attribute ‘python310Packages.drf-yasg’: warning: maintainers-missing Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/drf-yasg/default.nix:55:5:

   |
55 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python310Packages.extruct:

got build log for '/nix/store/sslm05lyj1n3vgx773w7cd9cqhvx5k1x-python3.10-extruct-0.13.0' from 'daemon' When evaluating attribute ‘python310Packages.extruct’: warning: unused-argument Unused argument: pytest-cov. Near pkgs/development/python-modules/extruct/default.nix:15:3:

   |
15 | , pytest-cov
   |   ^
python310Packages.jstyleson:

got build log for '/nix/store/fxlpdrn2h8ninblyzf0hzv6lq6lip851-python3.10-jstyleson-0.0.2' from 'daemon' When evaluating attribute ‘python310Packages.jstyleson’: warning: unused-argument Unused argument: pytest. Near pkgs/development/python-modules/jstyleson/default.nix:4:3:

  |
4 | , pytest
  |   ^
python310Packages.microdata:

got build log for '/nix/store/n42a4id319qx04blm2jyzi1bv9glfc8z-python3.10-microdata-0.8.0' from 'daemon' When evaluating attribute ‘python310Packages.microdata’: warning: unused-argument Unused argument: python. Near pkgs/development/python-modules/microdata/default.nix:4:3:

  |
4 | , python
  |   ^
python310Packages.openapi-core:

got build log for '/nix/store/crh2awjkc2bcay0midxcmzvrk19yzf3y-python3.10-openapi-core-0.14.2' from 'daemon' When evaluating attribute ‘python310Packages.openapi-core’: warning: unused-argument Unused argument: python. Near pkgs/development/python-modules/openapi-core/default.nix:23:3:

   |
23 | , python
   |   ^
python310Packages.pyrdfa3:

got build log for '/nix/store/lshlyny9ylfz61rfqxmgs7z4dai8fwrc-python3.10-pyrdfa3-3.5.3' from 'daemon' When evaluating attribute ‘python310Packages.pyrdfa3’: warning: unused-argument Unused argument: fetchpatch. Near pkgs/development/python-modules/pyrdfa3/default.nix:4:3:

  |
4 | , fetchpatch
  |   ^
python310Packages.recipe-scrapers:

warning: unused-argument Unused argument: pytest. Near pkgs/development/python-modules/recipe-scrapers/default.nix:10:3:

   |
10 | , pytest
   |   ^
python39Packages.django-cors-headers:

got build log for '/nix/store/zl32h58fmy0rgf679y1jr1q2a0pi9bvm-python3.9-django-cors-headers-3.13.0' from 'daemon' When evaluating attribute ‘python39Packages.django-cors-headers’: warning: maintainers-missing Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/django-cors-headers/default.nix:33:5:

   |
33 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python39Packages.django-scopes:

got build log for '/nix/store/xriw9hf98cf58djp36ldcb5rz7dwwkf1-python3.9-django-scopes-1.2.0.post1' from 'daemon' When evaluating attribute ‘python39Packages.django-scopes’: warning: unused-argument Unused argument: fetchpatch. Near pkgs/development/python-modules/django-scopes/default.nix:3:3:

  |
3 | , fetchpatch
  |   ^

warning: unused-argument Unused argument: coverage. Near pkgs/development/python-modules/django-scopes/default.nix:7:3:

  |
7 | , coverage
  |   ^
python39Packages.drf-yasg:

got build log for '/nix/store/ddzmb8raqnqi6kaa1i8rhyll6cw4klmr-python3.9-drf-yasg-1.21.3' from 'daemon' When evaluating attribute ‘python39Packages.drf-yasg’: warning: maintainers-missing Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/drf-yasg/default.nix:55:5:

   |
55 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python39Packages.extruct:

got build log for '/nix/store/k4w0pzrbpyapzzi7w284qzmsw6vi71hq-python3.9-extruct-0.13.0' from 'daemon' When evaluating attribute ‘python39Packages.extruct’: warning: unused-argument Unused argument: pytest-cov. Near pkgs/development/python-modules/extruct/default.nix:15:3:

   |
15 | , pytest-cov
   |   ^
python39Packages.jstyleson:

got build log for '/nix/store/vrhiigd63xsw9c48d4h8aa47nrpf7c87-python3.9-jstyleson-0.0.2' from 'daemon' When evaluating attribute ‘python39Packages.jstyleson’: warning: unused-argument Unused argument: pytest. Near pkgs/development/python-modules/jstyleson/default.nix:4:3:

  |
4 | , pytest
  |   ^
python39Packages.microdata:

got build log for '/nix/store/vn3ii8bblgc94q60y0h73aw0vn1jdbsj-python3.9-microdata-0.8.0' from 'daemon' When evaluating attribute ‘python39Packages.microdata’: warning: unused-argument Unused argument: python. Near pkgs/development/python-modules/microdata/default.nix:4:3:

  |
4 | , python
  |   ^
python39Packages.openapi-core:

got build log for '/nix/store/5ywgvlahg7i8vx8j3c8lk5rdlazlkqnb-python3.9-openapi-core-0.14.2' from 'daemon' When evaluating attribute ‘python39Packages.openapi-core’: warning: unused-argument Unused argument: python. Near pkgs/development/python-modules/openapi-core/default.nix:23:3:

   |
23 | , python
   |   ^
python39Packages.pyrdfa3:

got build log for '/nix/store/is8h4296mfcbih2g3254j75dp8i7qfkk-python3.9-pyrdfa3-3.5.3' from 'daemon' When evaluating attribute ‘python39Packages.pyrdfa3’: warning: unused-argument Unused argument: fetchpatch. Near pkgs/development/python-modules/pyrdfa3/default.nix:4:3:

  |
4 | , fetchpatch
  |   ^
python39Packages.recipe-scrapers:

warning: unused-argument Unused argument: pytest. Near pkgs/development/python-modules/recipe-scrapers/default.nix:10:3:

   |
10 | , pytest
   |   ^
tandoor-recipes:

warning: unused-argument Unused argument: lib. Near pkgs/applications/misc/tandoor-recipes/default.nix:1:3:

  |
1 | { lib
  |   ^

warning: unused-argument Unused argument: fetchFromGitHub. Near pkgs/applications/misc/tandoor-recipes/default.nix:3:3:

  |
3 | , fetchFromGitHub
  |   ^

warning: unused-argument Unused argument: fetchpatch. Near pkgs/applications/misc/tandoor-recipes/default.nix:4:3:

  |
4 | , fetchpatch
  |   ^
tests.nixos-functions.nixos-test:

Package is missing a meta section. If the package is using runCommand please make sure to inherit or create a meta section.

SuperSandro2000 avatar Sep 25 '22 22:09 SuperSandro2000

Please remove all the unused inputs.

SuperSandro2000 avatar Sep 25 '22 22:09 SuperSandro2000

Seems like recipe-scrapers' tests timed out during your nixpkgs-review run @SuperSandro2000, not sure if that would be an issue in hydra.

I removed all unused arguments from derivations.

ambroisie avatar Sep 26 '22 07:09 ambroisie

The frontend fails to build after rebasing onto master.

error: builder for '/nix/store/3whnarllgdzrvxhc3vy3ncwc9d78928y-tandoor-recipes-frontend-1.4.1.drv' failed with exit code 1;
       last 10 log lines:
       > yarn config v1.22.19
       > success Set "yarn-offline-mirror" to "/nix/store/3bmkrplw2iryiqbidsjfahdis8y75ikh-offline".
       > Done in 0.02s.
       > /nix/store/nmyb21xfs4ckwimd0n06pjg4wiqnlk3m-yarn-1.22.19/bin/yarn
       > yarn install v1.22.19
       > [1/4] Resolving packages...
       > [2/4] Fetching packages...
       > error @achrinza/[email protected]: The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.9.1"
       > error Found incompatible module.
       > info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
       For full logs, run 'nix log /nix/store/3whnarllgdzrvxhc3vy3ncwc9d78928y-tandoor-recipes-frontend-1.4.1.drv'.

mweinelt avatar Sep 29 '22 12:09 mweinelt

The frontend fails to build after rebasing onto master.

Weird, we are using nodejs-16_x in buildInputs. Could it be that nodePackages.yarn uses Node 18.9 and it is picking up that one instead?

EDIT: yup, nodejs = hiPrio nodejs-18_x; and yarn takes nodejs as an input, that does seem to be the source of this error.

ambroisie avatar Sep 29 '22 12:09 ambroisie