nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

enyo-launcher: 2.0.2 -> 2.0.5, renamed from enyo-doom

Open usrfriendly opened this issue 1 year ago • 5 comments

Description of changes

This is a new package, potentially a duplicate of enyo-doom, which has been changed to "enyo-launcher" and has a different upstream repo, and three minor version releases since (from 2.02 to 2.05). New Gitlab repo: https://gitlab.com/sdcofer70/enyo-launcher

I did not test for breaking dependent packages, as it has no dependent packages. I also only have access to x86_64-linux on NixOS right now, so it's all I could test the build on.

Things done
  • Built on platform(s)
    • [✅] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [✅ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [✅ ] Tested basic functionality of all binary files (usually in ./result/bin/)

usrfriendly avatar Aug 28 '22 03:08 usrfriendly

Result of nixpkgs-review pr 188557 run on x86_64-linux 1

1 package built:
  • enyo-launcher

Ofborg ran out of space, appears to be an infra problem.

bbjubjub2494 avatar Sep 08 '22 21:09 bbjubjub2494

Can we just rename the existing enyo-doom package and change its src URL? This doesn't warrant a new package imo.

tadfisher avatar Sep 09 '22 05:09 tadfisher

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/613

nixos-discourse avatar Sep 26 '22 07:09 nixos-discourse

@ofborg build enyo-launcher

SuperSandro2000 avatar Sep 26 '22 09:09 SuperSandro2000

Please rebase to fix the merge conflict and adjust the commit message to what I renamed the PR to.

SuperSandro2000 avatar Sep 26 '22 09:09 SuperSandro2000

Shoot, I probably need to squash those commits, but don't seem to be able to find them all with git rebase -i HEAD~2 which should have my merge that I used to rebase the commit. I'm working on that and will probably have it tomorrow.

usrfriendly avatar Sep 28 '22 03:09 usrfriendly