yuzu-{ea,mainline}: {2841,1092} -> {2901,1130}

[sbruder]

This also changes the update script for EA to fetch the two latest releases, filter for tags matching /^EA-[0-9]*/ and pick the latest one. This is required because recently the auto-updater (tag: continuous) is the latest release, which would have been picked by the update script.

It also updates the free icons patch, which is needed due to yuzu changing how they track licenses of files to REUSE. The comment is updated to reflect the workflow that is needed to create the patch, because pineapple does not include files beginning with a dot in its source.

Because new icons were added, the current version of the free icons patch still has four CC-BY-ND 3.0 icons (cf. https://github.com/yuzu-emu/yuzu/pull/8104#issuecomment-1214158492).

I’m not sure if we should wait until there is a patch available to replace all unfree icons or if we should merge this and accept the rebuilds it will cause for users.

Things done

• Built on platform(s)
  • [X] x86_64-linux
  • [ ] aarch64-linux
  • [ ] x86_64-darwin
  • [ ] aarch64-darwin
• [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• [ ] Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• [X] Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • [ ] (Package updates) Added a release notes entry if the change is major or breaking
  • [ ] (Module updates) Added a release notes entry if the change is significant
  • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• [X] Fits CONTRIBUTING.md.

[IvarWithoutBones]

I’m not sure if we should wait until there is a patch available to replace all unfree icons or if we should merge this and accept the rebuilds it will cause for users.

I do think it'd be better to wait in this case, as I believe the author of the PR we're patching in is planning on converting to the nonfree icons to free ones. We've updated not too long ago anyways, as far as I know theres no major features added in these updates.

Adding cc-by-nd-30 licensed icons in that patch kind of defeats its point.

[sbruder]

You’re right, the patch doesn’t really make sense in the form that is included in this PR, so I’ll wait until the PR is updated to also replace the newly added icons.

The reason why I updated, is that (at least on my system) the current yuzu in nixpkgs has unusually low performance, which is not the case with the the current versions. But that might very well be just an issue for me and I can just use a different version for the time being.

[IvarWithoutBones]

The reason why I updated, is that (at least on my system) the current mainline in nixpkgs has unusually low performance, which is not the case with the EA version currently in nixpkgs or the current mainline. But that might very well be just an issue for me and I can just use a different version for the time being

Hmm, it might be worth checking if we can just update mainline to the latest version where the old patch (with only free icons) applies, if it's any better there.

[IvarWithoutBones]

I've also reported files starting with a dot being stripped to pineapple developers, hopefully we can get that fixed.

[sbruder]

I just tested it again and it seems like even the current EA is affected (sorry for editing my comment a bazillion times). It looks like the last mainline version where the patch applies is 1108, which I just tested and it suffers from the same performance issue. I’ll try bisecting it.

[Docteh]

I went with tweaked gnome-icons, we'll see how temporary it is ;)

Bit late for this suggestion, but since the icons aren't directly used yet, could replace with something like the no texture texture from half life

I think the proper one is #FF00FF and #000000

[sbruder]

@Docteh Thanks for updating the PR and for also keeping us updated! Replacing the unfree icons with a placeholder is a good idea.

Because my performance issue wasn’t really fully reproducible, I didn’t manage to exactly pinpoint its issue, but it is definitely gone in the most recent versions. Now that this no longer introduces unfree icons, it should be good to go.