nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

gnome.mutter: Fix stride calculation when using dmabufs

Open fedeinthemix opened this issue 1 year ago • 0 comments

Sharing screen with applications using DMA-BUF at some screen resolutions results in a corrupted image. The added patch 'fix-stream-stride-2513.patch' fixes the problem by correcting the stride calculation. The patch has been merged into the main repository and should be included in GNOME 43.0, see https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2513.

Description of changes

Added patch 'fix-stream-stride-2513.patch' .

Things done
  • Built on platform(s)
    • [ x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
    • [ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • [ ] Fits CONTRIBUTING.md.

I've tested the patch on my NixOS system using the override below in 'configuration.nix' and checked that sharing my screen at 3440x1440 with 'obs-studio' produces the expected result.

  nixpkgs.overlays = [
    (self: super: {
      gnome = super.gnome.overrideScope' (gself: gsuper: {
        mutter = gsuper.mutter.overrideAttrs (oldAttrs: {
          patches = oldAttrs.patches ++ [
            # Fix mutter stride size
            /path-to-patch/fix-stream-stride-2513.patch
          ];
        });
      });
    })
  ];

I propose this patch to be back-ported to 'nixos-22.05'.

fedeinthemix avatar Aug 13 '22 12:08 fedeinthemix