nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

pdm: 1.14.0 -> 2.1.1

Open betaboon opened this issue 1 year ago • 9 comments

Description of changes
Things done
  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested, as applicable:
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [ ] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
    • [ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • [ ] Fits CONTRIBUTING.md.

cc @cpcloud

betaboon avatar Jul 26 '22 14:07 betaboon

i just bumped the versions of these two packages to the most recent ones.

bump @cpcloud

@mweinelt maybe you feel confident reviewing this ?

betaboon avatar Aug 02 '22 20:08 betaboon

@ofborg eval

mweinelt avatar Aug 11 '22 23:08 mweinelt

Too big to go into master.

mweinelt avatar Aug 12 '22 00:08 mweinelt

so is there any action for me to take here?

betaboon avatar Aug 13 '22 07:08 betaboon

Needs to retargeted at staging, see https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging.

mweinelt avatar Aug 13 '22 09:08 mweinelt

Needs to retargeted at staging

done.

just some well intended feedback here: would have been nice if the previous comment "to big ..." would have been somewhat more instructive. along the lines of "could you please rebase against and target staging as this is to big to go into master"

betaboon avatar Aug 13 '22 10:08 betaboon

betaboon requested review from kalbasit, Mic92, zowoq, thoughtpolice, marsam, matthewbauer, LnL7, stigtsp, zakame, NixOS/systemd and Ericson2314 as code owners 5 minutes ago

Did you read the linked guide? It makes sure this does not happen.

mweinelt avatar Aug 13 '22 10:08 mweinelt

Did you read the linked guide? It makes sure this does not happen.

I'm sorry for the noise i caused by not properly following the provided guide. I will try to do better in the future.

betaboon avatar Aug 13 '22 10:08 betaboon

Did you read the linked guide? It makes sure this does not happen.

I'm sorry for the noise i caused by not properly following the provided guide. I will try to do better in the future.

No worries! This happens to all of us at some point.

cpcloud avatar Aug 13 '22 12:08 cpcloud

@ofborg eval

mweinelt avatar Aug 30 '22 00:08 mweinelt

Tested on aarch64-linux and x86_64-linux

mweinelt avatar Sep 01 '22 20:09 mweinelt