nixpkgs icon indicating copy to clipboard operation
nixpkgs copied to clipboard

pomodoro: init at 0.1.0

Open auroraanna opened this issue 2 years ago • 5 comments

Description of changes
Things done
  • Built on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested, as applicable:
  • [x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • [x] Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
    • [ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • [X] Fits CONTRIBUTING.md.

auroraanna avatar Jul 20 '22 14:07 auroraanna

Result of nixpkgs-review pr 182212 run on x86_64-linux 1

1 package built:
  • pomodoro

auroraanna avatar Jul 20 '22 14:07 auroraanna

Just my 5c, I know that the project name is Pomodoro, but it just feels weird having such small utility taking ownership of the pomodoro attribute, given that Pomodoro is a general name for the process itself.

Maybe pomodoro-rs?

smancill avatar Jul 22 '22 02:07 smancill

I kind of understand your concern but also there's no other package named pomodoro and pomodoro-rs is not the name of the program. If there's gonna be another rust pomodoro package we'll have a problem too.

auroraanna avatar Jul 22 '22 12:07 auroraanna

Well, as you forked it, renaming the project to pomodoro-rs would be possible. The name of the binary can still be pomodoro. OTOH we also allowed a similar namespace-cluttering with exa or gobang (the latter being neither written in Go nor related to the board game).

wamserma avatar Jul 22 '22 13:07 wamserma

Result of nixpkgs-review pr 182212 run on aarch64-linux 1

1 package built:
  • pomodoro

wamserma avatar Jul 22 '22 13:07 wamserma

I put it in.

auroraanna avatar Sep 28 '22 20:09 auroraanna

@ofborg build pomodoro

SuperSandro2000 avatar Sep 28 '22 22:09 SuperSandro2000

@ofborg eval

SuperSandro2000 avatar Jan 23 '23 17:01 SuperSandro2000