nixos-search icon indicating copy to clipboard operation
nixos-search copied to clipboard
verified publisher icon NixOS

Fix wildcard search

Open ncfavier opened this issue 3 years ago • 10 comments

Fixes https://github.com/NixOS/nixos-search/issues/537 maybe.

ncfavier avatar Sep 09 '22 16:09 ncfavier

🚀 Deployed on https://631b6dfec65a852a22c5619c--nixos-search.netlify.app

github-actions[bot] avatar Sep 09 '22 16:09 github-actions[bot]

We had a wildcard search?

ysndr avatar Sep 09 '22 16:09 ysndr

We had a wildcard search?

Apparently.

[wildcard] query does not support [case_insensitive]

Hmm, I guess we're using a version of Elastic older than 7.10.0? (https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-wildcard-query.html)

ncfavier avatar Sep 09 '22 16:09 ncfavier

Yeah, 7.2.0. Shame.

ncfavier avatar Sep 09 '22 16:09 ncfavier

Maybe we can just remove the lowercase call in the frontend, so that we can at least match things using the proper capitalisation?

ncfavier avatar Sep 09 '22 16:09 ncfavier

That seems to work. Now at least extraDep returns a result.

ncfavier avatar Sep 09 '22 16:09 ncfavier

@garbas is it possible to elevate us onto a newer elastic version?

ysndr avatar Sep 09 '22 16:09 ysndr

There is 7.10.2 version available, would that work?

garbas avatar Sep 12 '22 06:09 garbas

Yes!

ncfavier avatar Sep 12 '22 08:09 ncfavier

Sorry I forgot to contact the Bonsai support, I've done it now. I'll keep you posted.

garbas avatar Oct 17 '22 21:10 garbas

Maybe we can merge this in the meantime?

ncfavier avatar Oct 30 '22 15:10 ncfavier

yeah, lets merge this. works a little better.

I also got news from bonsai (it for some reason went to my spam) that they will bring new cluster with 7.10 up. Then we could rework the query a bit.

garbas avatar Nov 02 '22 14:11 garbas