nixos-hardware
nixos-hardware copied to clipboard
NixOS
Adding the Legion Pro 7 16IRX9H model
Initially, I simply copied it from the 16IRX8H, but I am still having issues with WiFi and sound (to be resolved).
Ref.: https://psref.lenovo.com/Product/Legion/Legion_Pro_7_16IRX9H
Description of changes
Adding the Legion Pro 7 16IRX9H model, copy/paste from 16IRX8H.
Things done
- [X] Tested the changes in your own NixOS Configuration
- [X] Tested the changes end-to-end by using your fork of
nixos-hardwareand importing it via<nixos-hardware>or Flake input
@Mic92 I just copied it from https://github.com/NixOS/nixos-hardware/blob/master/lenovo/legion/16irx8h/default.nix is that wrong too? Should I fix it too in this same PR?
@felipelalli I noticed that we actually don't add nvidea to boot.initrd.kernelModule, which makes me wonder do you see any difference in having it in initrd? I.e. refreshing or changing resolution during boot?
@felipelalli I noticed that we actually don't add nvidea to
boot.initrd.kernelModule, which makes me wonder do you see any difference in having it in initrd? I.e. refreshing or changing resolution during boot?
Sorry, but I couldn't understand your question. Apologies, I am a newbie. I just copied the setup of a laptop similar to mine.
@felipelalli I am talking about this line:
boot.initrd.kernelModules = ["nvidia"];
When it's added does it flicker less during boot up. This line will put your nvidia driver into initrd and hence will initialize the graphic card earlier during boot. I believe not having it would make your graphic driver to be somewhat re-initialized once filesystem are mounted, resulting in a refreshing the screen, potentially changing the resolution
@Mic92 I have applied your suggestions, but pay attention that the same need to be done in 16irx8h.