nixops-aws icon indicating copy to clipboard operation
nixops-aws copied to clipboard

WIP: RDS: add engineVersion attribute

Open RaitoBezarius opened this issue 4 years ago • 1 comments

This adds the engine version attribute (e.g. PostgreSQL 12, etc.)

This PR only require I make the attribute optional so that it is backward compatible.

RaitoBezarius avatar Oct 10 '21 15:10 RaitoBezarius

I believe it should also be added to : https://github.com/NixOS/nixops-aws/blob/9690edc727a20ee35fd2f144fce9714e9262c095/nixops_aws/resources/types/ec2_rds_dbinstance.py#L5

Also, I would suggest to adapt the boto3 port work done per https://github.com/NixOS/nixops-aws/pull/120 and add this particular change ^^

tewfik-ghariani avatar Oct 12 '21 12:10 tewfik-ghariani