nixfmt

nixfmt copied to clipboard

Don't expand final list arguments of functions

4

Applies #233 to last arguments too Best review commit by commit --- This work is sponsored by [Antithesis](https://antithesis.com/) :sparkles:

infinisil

Having an empty multiline set as the last parameter in an application in a set puts it on an extra line

2

That title should describe it… sorry for the length of it. Given this input: ```nix { test = app { }; } ``` I would expect the expression not to...

dasJ

`f x.a or b` should be formatted to `f (x.a or b)`

1

### Description This is a ferociously confusing parse, as precedent from Nix and Haskell would have you expect that no operator binds tighter than function calls, and the spaced keyword...

emilazy

Git pre-commit/push hook

9

We should have this in Nixpkgs for https://github.com/NixOS/nixpkgs/pull/326407. Here are some notes for that: - For every push/commit, it should verify that changed and new files are formatted - For...

infinisil

Appending an optional string / array causes the entire expression to be reformatted

1

### Description I don't really mind either way, but filing this in case someone might find the following useful. I think this diff could have been less noisy: https://github.com/NixOS/nixpkgs/pull/280482/commits/eac595161a60da7d695d46469e2e849d82da57d6 ###...

CyberShadow

It was suggested I file a separate issue for this: ---- Just to propose one additional use case for `/* */` comment (non-)formatting: it's possible to toggle a block comment...

ian-h-chamberlain

Formatting only specific line ranges

1

The context for this is [here](https://github.com/NixOS/nixpkgs/pull/326407#issuecomment-2232306419). For a more future-proof solution, we should consider implementing a partial formatter mode, which can be told to format only specific line ranges of...

infinisil