Weird formatting of optionals

[jtojnar]

Description

When formatting a long line with condition and a list, splitting the condition is preferred over the list. Would be nice to have some heuristic that would prefer the opposite.

Small example input

{
  NIX_CFLAGS_COMPILE = lib.optionals (lib.versionOlder prev.php.version "7.2" && pkgs.stdenv.cc.isClang) [" -Wno-implicit-int"];
}

Expected output

{
  NIX_CFLAGS_COMPILE =
    lib.optionals (lib.versionOlder prev.php.version "7.2" && pkgs.stdenv.cc.isClang)
      [
        " -Wno-implicit-int"
      ];
}

Actual output

{
  NIX_CFLAGS_COMPILE = lib.optionals (
    lib.versionOlder prev.php.version "7.2" && pkgs.stdenv.cc.isClang
  ) [ " -Wno-implicit-int" ];
}

I can get the preferred formatting if I split the array onto multiple lines. For example

{
  NIX_CFLAGS_COMPILE = lib.optionals (lib.versionOlder prev.php.version "7.2" && pkgs.stdenv.cc.isClang) [" -Wno-implicit-int"
  ];
}```

[Majiir]

Another example, without optionals:

Input:

{
  cycle = lib.drop (lib.lists.findFirstIndex (lib.flip lib.elem sorted.loops) 0 sorted.cycle) sorted.cycle;
}

Expected output:

{
  cycle = lib.drop (
    lib.lists.findFirstIndex (lib.flip lib.elem sorted.loops) 0 sorted.cycle
  ) sorted.cycle;
}

Or perhaps:

{
  cycle = lib.drop
    (lib.lists.findFirstIndex (lib.flip lib.elem sorted.loops) 0 sorted.cycle)
    sorted.cycle;
}

Actual output:

{
  cycle = lib.drop (lib.lists.findFirstIndex (lib.flip lib.elem sorted.loops) 0
    sorted.cycle
  ) sorted.cycle;
};

[piegamesde]

okay this example is a lot weirder, and might be a different issue. I'll investigate