nixfmt icon indicating copy to clipboard operation
nixfmt copied to clipboard

RFC 166 implementation tracking issue

Open infinisil opened this issue 3 months ago • 9 comments

Now that RFC 166 is accepted, let's commence with the implementation!

Here's a very rough todo-list, most of which will be fairly quick.

  • [x] Update README to mention WIP state: https://github.com/serokell/nixfmt/pull/154
  • [x] Create Nix formatting GitHub team: https://github.com/orgs/NixOS/teams/nix-formatting/members
    • [x] Add @Sereja313 to the team, couldn't do that myself since they're not already in the organisation. This was requested in the issue below
  • [x] Move repo under NixOS org: https://github.com/serokell/nixfmt/issues/155
  • [x] Decide on merge rules: https://github.com/NixOS/nixfmt/rules/523613?ref=refs%2Fheads%2Fmaster
  • [x] Create a team page in the repo: https://github.com/serokell/nixfmt/pull/156
  • Create a GitHub project board Let's only start using one if we feel the need for it
  • [x] Create a nixos.org page for the team: https://github.com/NixOS/nixos-homepage/pull/1337
  • [x] Move the RFCs initial standard format into the repo: https://github.com/NixOS/nixfmt/pull/158
  • [x] Merge https://github.com/serokell/nixfmt/pull/118
  • [x] Set up automated testing
    • Run test suite in CI: NixOS/nixfmt#172
    • Each PR needs to be tested on the entirety of Nixpkgs: https://github.com/NixOS/nixfmt/issues/163
  • [ ] Fully review the code
    • Check that it conforms to the specification
    • Document sufficiently
    • Simplify if possible
  • [ ] Tool documentation
  • [ ] Create a release and announce it
    • Marketing, celebration, Discourse, blog post, NixCon talk, etc.
    • Update Nixpkgs and Nix docs, e.g. contributor guide, etc.
  • [ ] Update nix fmt to point to nixfmt
  • [ ] Reformat Nixpkgs: https://github.com/NixOS/nixpkgs/issues/322520
    • Also on other repos
    • Also, Nix code in documentation and elsewhere

Ping @piegamesde @tomberek @0x4A6F @Sereja313 @dasJ

infinisil avatar Mar 12 '24 23:03 infinisil