nix icon indicating copy to clipboard operation
nix copied to clipboard

Published 20 hours ago • verified publisher icon NixOS

Nixpkgs lib tests update

Open roberth opened this issue 5 months ago • 3 comments

Motivation

Nixpkgs currently has a failing test in

  • https://github.com/NixOS/nixpkgs/pull/285264

This might be a regression.

This PR

The goal of this PR is to update the Nixpkgs pin so that we can run the latest tests again, including @infinisil's extensive filesets tests that found the change in behavior.

TODO

  • [x] fail as it should https://github.com/NixOS/nix/actions/runs/7744562814/job/21118568885?pr=9900#step:6:6217
  • [ ] get the extra entrypoint into Nixpkgs upstream
    • https://github.com/NixOS/nixpkgs/pull/290831
  • [ ] resolve any remaining issues

Follow-up?

  • Also run pkgs/test/release/default.nix?

Context

  • Depends on https://github.com/NixOS/nixpkgs/pull/290831

  • Regressions that would have been caught if we updated Nixpkgs earlier

    • #9901

Priorities and Process

Add :+1: to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

roberth avatar Feb 01 '24 16:02 roberth

Tracked down the regression: https://github.com/NixOS/nix/issues/9901

infinisil avatar Feb 01 '24 20:02 infinisil

:warning: Dpulls not installed on repository NixOS/nixpkgs. Checkout our quickstart for how to install.

dpulls[bot] avatar Feb 23 '24 09:02 dpulls[bot]

:warning: Dpulls not installed on repository NixOS/nixpkgs. Checkout our quickstart for how to install.

dpulls[bot] avatar Feb 23 '24 10:02 dpulls[bot]

:warning: Dpulls not installed on repository NixOS/nixpkgs. Checkout our quickstart for how to install.

dpulls[bot] avatar Feb 27 '24 15:02 dpulls[bot]

Marking as draft again while waiting for

  • #9546

which unfortunately wasn't completed yet, and I've duplicated some part of that work independently :(

roberth avatar Feb 28 '24 00:02 roberth

Discussed during the Nix maintainers meeting on 2024-02-28. No agreement as to whether we want to follow nixos-unstable, to discuss

  • Originally just wanted to add a nixpkgs lib test

  • Also tracking nixos-unstable

  • Agreement on following nixos-unstable rather than the latest release?

    • @thufschmitt: yes
    • @edolstra: not sure

thufschmitt avatar Feb 29 '24 06:02 thufschmitt

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-02-28-nix-team-meeting-129/40499/1

nixos-discourse avatar Feb 29 '24 07:02 nixos-discourse

Discussed during the Nix maintainers meeting on 2024-03-04. We won't track nixos-unstable as the primary target, but we also want to test against it. Opened https://github.com/NixOS/nix/issues/10156 for that.

  • Need to have a job that builds against nixos-unstable so that we don't spend three months updating to the latest release against
    • Can be a side job, not the main one
    • A bit tricky because hydra doesn't have --override-input. But will find a way

thufschmitt avatar Mar 05 '24 07:03 thufschmitt

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-03-04-nix-team-meeting-minute-130/40830/1

nixos-discourse avatar Mar 05 '24 07:03 nixos-discourse

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-03-06-nix-team-meeting-131/42959/1

nixos-discourse avatar Apr 08 '24 15:04 nixos-discourse