hydra icon indicating copy to clipboard operation
hydra copied to clipboard

Gitlab support

Open Ericson2314 opened this issue 7 years ago • 6 comments
trafficstars

It would be nice if hydra supported GitLab in all the ways (3 plugins, I believe) it supports GitHub.

Ericson2314 avatar Oct 25 '18 21:10 Ericson2314

@Ericson2314 I have a PR to add the Gitlab MR support. Do not hesitate to review it:)

nlewo avatar Nov 08 '18 07:11 nlewo

@nlewo oh, great!

Ericson2314 avatar Jan 05 '19 00:01 Ericson2314

https://github.com/NixOS/hydra/pull/592 is said PR. (I hope to get to this quite soon, but linking it here for posterity.)

Ericson2314 avatar Jan 05 '19 00:01 Ericson2314

#649 for gitlab status support.

globin avatar Apr 15 '19 15:04 globin

Hey @globin i have a question about the status support plugin:

https://github.com/NixOS/hydra/blob/master/src/lib/Hydra/Plugin/GitlabStatus.pm#L63 this line does not work with SSH checkout URLs (like "[email protected]:foo/bar.git") but only with http(s) URLs.

So i have the impression that you authenticate via HTTP(S), but i would need that for private repositories. Is that a use case that we share? For now, i am running a patched version of the plugin that simply hardcodes the gitlab server as we have only a single one. But i'd prefer to not patch it and authenticate properly via HTTPS.

tfc avatar Jun 27 '19 12:06 tfc

Hey @globin i have a question about the status support plugin:

https://github.com/NixOS/hydra/blob/master/src/lib/Hydra/Plugin/GitlabStatus.pm#L63 this line does not work with SSH checkout URLs (like "[email protected]:foo/bar.git") but only with http(s) URLs.

So i have the impression that you authenticate via HTTP(S), but i would need that for private repositories. Is that a use case that we share? For now, i am running a patched version of the plugin that simply hardcodes the gitlab server as we have only a single one. But i'd prefer to not patch it and authenticate properly via HTTPS.

I just ran into this myself. The offending line is here - it tries to parse the SSH host as a URI.

An easy fix would be to use another string input for the domain.

hacker1024 avatar Sep 19 '23 02:09 hacker1024