nitrokey-app2 icon indicating copy to clipboard operation
nitrokey-app2 copied to clipboard

Time Exeption don't work Propaly

Open isa10110 opened this issue 1 year ago • 3 comments

Please add something like a proper working exception if no one presses the activation on the Fido key (Nitro Key 3A NFC)

I used your flatpack build.

image

ERROR_log.txt

please fix that :)

isa10110 avatar Oct 08 '24 18:10 isa10110

Most of these are caught - thanks for finding a not caught one. But you miss to mention what exactly you've been doing. I did reproduce this behavior like this:

  • create a TOTP secret with touch confirmation
  • request a OTP
  • do not confirm this with a user presence check on the Nitrokey 3
  • non-caught error like the above will show up

did you find any other case in which such an error is not caught properly ?

daringer avatar Oct 09 '24 09:10 daringer

I installed your app from flathub. I created a TOTP key saved the key generation. tried to get a totp key generated. I don't pressed the Autentificaton button on the Nitokey 3A NFC and after a half minute of waiting the app crashed

It's a bad handling of timeout or something possible regarding the Python version you are shipping and the log attached.

I use a blank kubuntu for this test Kubuntu 24.04.1 LTS x86_68 probably you can reproduce it there :)

isa10110 avatar Oct 09 '24 10:10 isa10110

I repuduced that behavior again on a different machine with different keys

isa10110 avatar Oct 10 '24 13:10 isa10110