nitrokey-app icon indicating copy to clipboard operation
nitrokey-app copied to clipboard

Does this work with libnitrokey 3.4.1?

Open benoliver999 opened this issue 6 years ago • 5 comments

The README states that you need version 3.3 of libnitrokey yet the latest release is 3.4.1 - is this just an outdated readme or does it genuinely not work? I am trying to use nitrokey-app 1.3.2.

benoliver999 avatar Aug 23 '18 10:08 benoliver999

Hi! This is a minimal required version of libnitrokey, sorry for confusion. Do you experience issues with such tandem? What is your OS?

Edit: CMake does the check while compiling: https://github.com/Nitrokey/nitrokey-app/blob/d6fad2bd1aecbda2e36d4e9873f613ef5bf7649d/CMakeLists.txt#L210

szszszsz avatar Aug 23 '18 11:08 szszszsz

No issues, just trying to clear it up for the AUR, it's causing dependency issues because they thought it had to be frozen at 3.3. Thanks for the pointer!

benoliver999 avatar Aug 23 '18 11:08 benoliver999

You are welcome! I have corrected the Readme too.

szszszsz avatar Aug 23 '18 12:08 szszszsz

Actually I see, that latest NK App is not compiling due to some deprecated API calls. I will correct that in a moment.

szszszsz avatar Aug 23 '18 12:08 szszszsz

Hi!

When it'll works with the v3.4.1 of the lib, please don't forget to update the libnitrokey submodule in this repository to the correct version (or remove the submodule if it is no more used as a reference) and publish a new tagged release.

Thank you very much :)

milouse avatar Aug 23 '18 12:08 milouse