le-git-graph icon indicating copy to clipboard operation
le-git-graph copied to clipboard

fix: commits button not showing consistently

Open vinhyan opened this issue 1 year ago • 3 comments

This PR fixes issue #81.

Now the Commits button/tab is always available when navigating back from other tabs, or clicking on the browser's back button.

https://github.com/user-attachments/assets/a9cb4cc3-cee2-4839-9462-7915cc435751

vinhyan avatar Dec 10 '24 04:12 vinhyan

Hey, This is awesome. It fixes the issue for the most part. There is one side effect that came with the fix though. When a user installs the extension for the first time, they are usually taken to a first-run-experience page. It is a custom url that is handled by the extension. You can try opening the following url with the original extension installed and see it in action.

https://github.com/NirmalScaria/le-git-graph/?fre=true&reason=install

With your changes, this page no longer works. It shows the github with a blank overlay instead. I would be happy to merge the PR if you could get some fix for this issue.

NirmalScaria avatar Dec 28 '24 08:12 NirmalScaria

Hi @NirmalScaria! Been long overdue but the FRE has been fixed. Please review. Thanks!

https://github.com/user-attachments/assets/063eb053-a6ba-4a40-b224-ff768617dbde

vinhyan avatar Jan 29 '25 23:01 vinhyan

Hey, sorry for the delay. I just had a look at it. The FRE issue seems fixed. But, if you go to issues tab and come back to commits tab, the width of the commits ui is unusually wide. it is breaking the consistency of the UI. Could you have another iteration for it?

NirmalScaria avatar May 18 '25 08:05 NirmalScaria