UIDeviceComplete icon indicating copy to clipboard operation
UIDeviceComplete copied to clipboard

Update DeviceModel.swift

Open jminutaglio opened this issue 1 year ago • 2 comments

Adds:

  • iPad Air M2 11 & 13
  • iPad Pro M4 11 & 13

jminutaglio avatar May 19 '24 17:05 jminutaglio

adds new iPads May 2024

jminutaglio avatar May 19 '24 17:05 jminutaglio

Hi @jminutaglio,

Apologies for the delay, was busy with a new app launch recently.

From what I can tell from Xcode 15.4, the correct model numbers should be:

Device Size Model
iPad Air M2 11 inch iPad14,8
iPad14,9
iPad Air M2 13 inch iPad14,10
iPad14,11
iPad Pro M4 11 inch iPad16,3-A
iPad16,3-B
iPad16,4-A
iPad16,4-B
iPad Pro M4 13 inch iPad16,5-A
iPad16,5-B
iPad16,6-A
iPad16,6-B

As you can see, there's an oddity here, with the pro models having a A/B suffix, which is why I have yet to modify the codes yet, as I do not know what it meant, and whether if it is even reflected during runtime.

In Xcode's device_traits.db there's a "ThinningConfiguration" column that corresponds to A/B, but no further ideas on it.

Interestingly the M2 iPad Pros (14,3 to 14,6) have them too. I wonder if the current implementation of ours for those devices work properly.

vincentneo avatar Jun 07 '24 09:06 vincentneo

Interestingly the M2 iPad Pros (14,3 to 14,6) have them too. I wonder if the current implementation of ours for those devices work properly.

Just checked, M2 iPad Pro (14,4) is detected correctly, which means the A/B suffix does not matter.

(And I neglected the whole thing for too long - will try to update the project to include the latest devices soon)

vincentneo avatar Sep 10 '24 16:09 vincentneo

Closed in favour of #99

vincentneo avatar Sep 10 '24 17:09 vincentneo