Nintorch
Nintorch
While looking at Calinou's gamepad testing review I noticed that the controllers' names are different on different platforms, and I found a related issue: https://github.com/godotengine/godot/issues/96756 . I think this should...
I've changed the code to work in a single thread just like older joypad implementations and removed the code for older implementations for Windows and Linux (MacOS code is shared...
We can probably disable the SDL events subsystem so we can delete the other ones, and rewrite the code so it doesn't use SDL events. For now it's not possible...
> Does this PR have no impact on Android? > Or are tests on Android necessary? > > -------------- > > Remove unused SDL files > > ... > >...
Good news, I was able to remove a lot of unnecessary code, including the dummy subsystems! (except the sensor one, we will need it later when we add joypad gyroscope,...
List of issues the previous SDL input PR was referenced in, i.e list of issues this PR might fix but they require testing: https://github.com/godotengine/godot/issues/87112 https://github.com/godotengine/godot/issues/78805 https://github.com/godotengine/godot/issues/65308 https://github.com/godotengine/godot/issues/94265 https://github.com/godotengine/godot/issues/94585 https://github.com/godotengine/godot/issues/55448 https://github.com/godotengine/godot/issues/89136
> Using `use_llvm=yes` seems like it might fail. > > ``` > thirdparty/sdl/core/linux/SDL_evdev.c:375:29: error: call to undeclared function 'SDL_SendKeyboardKey'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]...
Rebased and included a define to allow SDL to use libudev. But I'm not sure if Calinou's hotplugging problem on Linux happens because of libudev being missing when he was...
I think this has been fixed with 4.2 beta I just tested a small (private) 2D project of mine and an empty 2D project in both 4.1.1 and 4.2 beta...
Since SDL input driver was merged recently, I think it will be possible to implement a platform-independent solution using SDL functions like [SDL_AttachVirtualJoystick](https://wiki.libsdl.org/SDL3/SDL_AttachVirtualJoystick), [SDL_SetJoystickVirtualButton](https://wiki.libsdl.org/SDL3/SDL_SetJoystickVirtualButton), etc.