PhpTikaWrapper icon indicating copy to clipboard operation
PhpTikaWrapper copied to clipboard

update symfony

Open youngbobby opened this issue 5 years ago • 8 comments

Update Symfony/process to fix conflict with Laravel

youngbobby avatar Sep 22 '19 15:09 youngbobby

Hello and thank you. I’ll review this tomorrow (this requires a version bump to >=7.2) and release a new minor(major?) version.

NinoSkopac avatar Sep 22 '19 22:09 NinoSkopac

I'm not sure. Laravel does require >=7.2 at the moment anyway. Please let me know your findings.

youngbobby avatar Sep 23 '19 07:09 youngbobby

After this is merged and released, minor version will be bumped (https://blog.whiteoctober.co.uk/index.html%3Fp=3415.html)

NinoSkopac avatar Sep 23 '19 15:09 NinoSkopac

@youngbobby I've just pushed a commit with proper PHP and PHPUnit versions, however, I'm unable to get the tests running.

Running ./vendor/bin/phpunit returns No tests executed! - I need the tests to pass before merging.

Can you assist?

NinoSkopac avatar Sep 23 '19 16:09 NinoSkopac

Very weird. I experience the same issue too.

youngbobby avatar Sep 25 '19 08:09 youngbobby

Any update with this ?

I really need to use this awesome package.

youngbobby avatar Oct 04 '19 14:10 youngbobby

No, I never got down to figuring this out, so it's stuck.

NinoSkopac avatar Oct 08 '19 10:10 NinoSkopac

Any idea how I can install manually like from this issue https://github.com/NinoSkopac/PhpTikaWrapper/issues/1 ?

youngbobby avatar Oct 10 '19 09:10 youngbobby