Nino Floris
Nino Floris
Thanks! I found these two pages to give a decent overview https://cloud.google.com/storage/docs/authentication/signatures https://cloud.google.com/storage/docs/migrating#authentication it looks a lot like the rsa signing in terms of query params and payload.
Meant to reply here earlier. Thanks for bringing it up and letting me know. We can wait, it's just something on our radar to improve when we can.
I would love something like this to be merged into here, OIDC is well established by now and of great use.
@dsyme this is indeed producing invalid IL, hit it today as well.
Specifically this pattern https://github.com/dotnet/fsharp/issues/12994#issuecomment-1103390228 bit us today again, given the compiler is effectively outputting invalid IL could this version of the bug also be fixed for 7.0? @vzarytovskii I might...
Yes, modulo the improved representation of the conversion info. Also https://github.com/dotnet/fsharp/issues/12946 is similarly fixed but still open.
Maybe this should be combined with similar work in #13063? I had similar thoughts that it may need a richer model to capture the different tdc forms, though ideally it...
Fun test failure, the dumped IL is different on my machine by one dot, probably some ildasm culture output difference. CI error: ``` FSharp.Compiler.UnitTests.TypeDirectedConversionTests.float converts to System.Nullable in method call...
I included the fix for #12946 as well (could easily be split out if preferred). I've written about the source of the current broken behavior here https://github.com/dotnet/fsharp/issues/12946#issuecomment-1217121581.
Ok so as mentioned offline, the only thing that's left to decide on is whether we should actually begin to emit the 'builtin conversion' warning under test here for Nullable...