EnvisEdge icon indicating copy to clipboard operation
EnvisEdge copied to clipboard

Added and improved inline documentation

Open imanishbarnwal opened this issue 2 years ago • 10 comments

Description

Added inline documentation for saver_utils.py as instructed in the issue.

Relevant Issue

Issue #193

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

imanishbarnwal avatar May 03 '22 07:05 imanishbarnwal

Deploy Preview for goofy-agnesi-4565cb canceled.

Name Link
Latest commit 801dd2f8c5908fd77c072134868f019850373af3
Latest deploy log https://app.netlify.com/sites/goofy-agnesi-4565cb/deploys/6273cdc4ad020f0008a66d0c

netlify[bot] avatar May 03 '22 07:05 netlify[bot]

@imanishbarnwal Can you please follow the Pep8 guidelines!!

divyanshugit avatar May 03 '22 16:05 divyanshugit

Hey @divyanshugit, I fixed the Pep8 issue but still, the Pytests error is there.

imanishbarnwal avatar May 03 '22 18:05 imanishbarnwal

Right now, You don't have to worry about the PyTest error. Ramesht is working on that.

divyanshugit avatar May 04 '22 00:05 divyanshugit

Okay thanks, so can I put this PR in my proposal and form? @divyanshugit

imanishbarnwal avatar May 04 '22 08:05 imanishbarnwal

It's your decision. If you think, it will be helpful then you can add it.

divyanshugit avatar May 04 '22 08:05 divyanshugit

You can also take reference from the current docs !!

ramesht007 avatar May 05 '22 05:05 ramesht007

Hey @ramesht007, I am not able to fix this Pytests unittests error rest are done. Kindly help me with this.

imanishbarnwal avatar May 05 '22 15:05 imanishbarnwal

@imanishbarnwal You don't have to worry about it. He will take care of PyTest error

divyanshugit avatar May 05 '22 15:05 divyanshugit

@imanishbarnwal You don't have to worry about it. He will take care of PyTest error

Okay sure, thanks.

imanishbarnwal avatar May 05 '22 15:05 imanishbarnwal