EnvisEdge icon indicating copy to clipboard operation
EnvisEdge copied to clipboard

🚨 Tests: Add new Identifier Data Structure Tests

Open ayush268 opened this issue 3 years ago • 2 comments

🛩 Where?

Code Location: https://github.com/NimbleEdge/RecoEdge/blob/75c397a4d911cbea04f2c2913a95ccc8642d5bb6/scala_core/src/test/scala/org/nimbleedge/recoedge/models/IdentifierSpec.scala#L114

The Data Structure + Functionality to be tested: https://github.com/NimbleEdge/RecoEdge/blob/75c397a4d911cbea04f2c2913a95ccc8642d5bb6/scala_core/src/main/scala/org/nimbleedge/recoedge/models/Identifier.scala

💭 Description

The Identifier is the Data Structure for the FLSystem.

The Identifier abstract class, is extended in the following classes:

  • OrchestratorIdentifier
  • AggregatorIdentifier
  • TrainerIdentifier

We are using the ScalaTest library for testing: https://www.scalatest.org/user_guide

You can check out the following pre-written tests as a reference to understand as well:

  • https://github.com/NimbleEdge/RecoEdge/blob/75c397a4d911cbea04f2c2913a95ccc8642d5bb6/scala_core/src/test/scala/org/nimbleedge/recoedge/models/IdentifierSpec.scala#L61
  • https://github.com/NimbleEdge/RecoEdge/blob/75c397a4d911cbea04f2c2913a95ccc8642d5bb6/scala_core/src/test/scala/org/nimbleedge/recoedge/models/IdentifierSpec.scala#L94

Type of Test

Unit test

👀 Have you spent some time to check if this issue has been raised before?

  • [X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

  • [X] I read the Code of Conduct

ayush268 avatar Jan 20 '22 17:01 ayush268

I'll take up this issue!

gagans20 avatar Jan 22 '22 10:01 gagans20

Great!

ayush268 avatar Jan 23 '22 12:01 ayush268