Nima Sarajpoor

> The only thing that I noticed was that, in your case, it says: > > ``` > 84 files would be left unchanged. > ``` > > But, in...

Yeah...if I cannot find the file, or the cause of this problem, I may create a new, clean branch and apply the changes there and then submit another PR. If...

@seanlaw I am going through the `stump` right now. I am proposing the following design: We can create a new function `stump_topk`, and then: ``` # in stump def stump(....,...

@seanlaw I think I should better submit a PR first (in which I just modify the current module without creating new function). Then, you can provide your comments there. I...

> I would prefer trying to modify the existing functions by adding the relevant and needed data structures. If you add a `stump_topk` function then it will cause too much...

(@seanlaw You beat me to it!) @JaKasb Thanks for sharing your knowledge and the paper! > k-NN for each distance-matrix row ? k-NN for each distance-matrix column ? Are these...

@seanlaw > Sounds good? Yes! That makes sense! > We need to be pragmatic and perfect the things that are actually worth perfecting and that affects the largest number of...

I am trying to write `test_stump_topk.py` which is basically the same as `test_stump.py`. I just need to replace `naive.stump` with `naive.stump_topk` (a new function that I added to `naive.py`). However,...

@seanlaw I decided to submit a PR so you can see if I got your point correctly or not. For now, I skipped the use of `naive.stamp` in the tests.

Thanks for the clarification. I will continue discussion on the PR #595. > Would you mind doing this and then updating any tests that use `naive.mass`? Sure. I can create...