Any plans to comply with toml v1.0.0?

[sealmove]

Hey, toml has reached version 1. Anyone up for adjusting this project to be consistent with it?

[PMunch]

Thanks for the notification, we should definitely update this to be compatible with v1.0.0.

EDIT: I can see that it's still a release candidate, but we should start working towards it anyways. Historically the test suite for TOML is always lagging behind though, so it's not the easiest task in the world.

[EchoPouet]

Version 1.0.0 has been released since the beginning of the year.

[PMunch]

Any test-suite yet that we can work against?

EDIT: For reference this is the one I've used to verify the parser against thus far: https://github.com/BurntSushi/toml-test

[kaushalmodi]

@PMunch Would this help: https://github.com/status-im/nim-toml-serialization/pull/36/files

[kaushalmodi]

@PMunch This seems to be the latest test suite: https://github.com/iarna/toml-spec-tests

[PMunch]

Hmm, with that one we need to implement a YAML output writer as well

[kaushalmodi]

@PMunch

I noticed that the Burntsushi toml-test project has now a new maintainer and it's updated to include TOML v1.0.0 tests.

To install:

1. Install go 1.16 or newer
2. go get -u -v github.com/BurntSushi/toml-test/cmd/toml-test@master
3. toml-test decoder/decoder

With that, I am now getting 49 fails.

toml-test [decoder/decoder]: using embeded tests: 231 passed, 49 failed

[kaushalmodi]

Ref: https://github.com/NimParsers/parsetoml/commit/83de3f36e00e7525ee731d3a6e92e4d221995e5c

Now this passes nimble run_toml_test_with_skips. In this task:

• 49 v1.0.0 specific failing tests are being skipped,
• 1 failing test on Windows is also being skipped: https://github.com/NimParsers/parsetoml/issues/51

This issue can be closed once nimble run_toml_test passes 100% on Linux.