zkLLVM icon indicating copy to clipboard operation
zkLLVM copied to clipboard

Move asserts definition to crypto3

Open makxenov opened this issue 10 months ago • 2 comments

Asserts from assigner could be used in another repositories as well, so we decided to move it to crypto3. Required steps:

  • [ ] Copy the file into crypto3 https://github.com/NilFoundation/crypto3-block/pull/77
  • [ ] Remove the original file and update paths in assigner
  • [ ] Update paths in zkllvm main repository

makxenov avatar Mar 26 '24 14:03 makxenov

It would be nice also to have this variant of todo function as well:

void todo(const std::string &msg, const char *filename, unsigned line);

Right now you can't write:

std::string s("world");
TODO("hello " + s);

I missed this variant when I was implementing this.

aleasims avatar Mar 27 '24 19:03 aleasims

We have some custom asserts defined in zkllvm-blueprint as well (here). Maybe we can replace them also. Blueprint is already using crypto3 library anyways.

aleasims avatar Apr 08 '24 12:04 aleasims