crypto3 icon indicating copy to clipboard operation
crypto3 copied to clipboard

Inconsistent traits across modules

Open hgedia opened this issue 2 years ago • 0 comments

We seem to have inconsistent trait definitions across modules. This makes it harder to have a singular concept in documentation. ex : https://github.com/NilFoundation/crypto3-pubkey/blob/7fbbf43cbf6fa88ddf0051646321eed2fb6b237e/include/nil/crypto3/detail/type_traits.hpp#L212 and https://github.com/NilFoundation/crypto3-algebra/blob/311bf0dbdfbb06407599c150c4738d685e10e5f4/include/nil/crypto3/algebra/type_traits.hpp#L79

This issue is to resolve inconsistencies across different modules.

ps: is_curve definition is incorrect as it includes pairing element of g2/gt and perhaps needs a new trait for pairing curves.

hgedia avatar Nov 04 '22 15:11 hgedia