f16 icon indicating copy to clipboard operation
f16 copied to clipboard

Emesary damage system chokes on certain callsigns

Open NikolaiVChr opened this issue 3 years ago • 4 comments

If AI callsign is longer than 7 chars, it will mess up the notifications, and armamentInFlight flags (thrust and active-radar) will be random values.

If callsign contain space it will not match since emesary removes that under decoding and hit notifications will not work.

Note to self: left("Niko", 7) == nil

NikolaiVChr avatar Jul 15 '22 07:07 NikolaiVChr

I suspect this issue is related to #475

NikolaiVChr avatar Jul 15 '22 07:07 NikolaiVChr

Pilot testimony: well, for example as from what i tested with him. today earlier, XXX and four numbers works well for his FlightGear, but XXXXX and 2 numbers not works. Also it works better without 0s, just bigger numbers... its very strange for example XXXXX07 not works while XXX1221 works perfectly

NikolaiVChr avatar Jul 15 '22 07:07 NikolaiVChr

4f893d48427a574c042ccefad2269c941ae8ea44 attempts to fix this

NikolaiVChr avatar Jul 15 '22 21:07 NikolaiVChr

It seems fixed, but keeping this issue open, so we don't forget this issue in future commits that communicate with emesary.

NikolaiVChr avatar May 14 '23 00:05 NikolaiVChr